All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	infra-steering@kernel.org, Git Mailing List <git@vger.kernel.org>
Subject: Re: Sources for 3.18-rc1 not uploaded
Date: Wed, 22 Oct 2014 11:42:48 +0200	[thread overview]
Message-ID: <54477C18.5060806@drmicha.warpmail.net> (raw)
In-Reply-To: <xmqqwq7tz3wt.fsf@gitster.dls.corp.google.com>

Junio C Hamano schrieb am 21.10.2014 um 20:14:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> Unfortunately, the git archive doc clearly says that the umask is
>> applied to all archive entries.
> 
> Is an extended pax header "an archive entry"?  I doubt it, and the
> above is not relevant.  The mode bits for the archive entry that it
> applies to does not come from there.

The problem seem to be old tar versions which mis-take the extensions
for archive entries, aren't they?

> See my other message for my final judgement on this one.  I wouldn't
> have minded if the original used the same umask for those ignored
> mode bits, but changing the bits to be ignored after the fact is not
> helping any real use case and only hurts existing users.
> 
> That is not to say that we cannot later fix bigger issues in the
> output.  I just do not see that otherwise-unused mode bits in the
> extended pax header big enough an issue to spend brain cycles to
> carefully lay and execute transition plans to avoid breaking
> existing users.

My question to Brian still stands which existing users he was trying to
cater for with his patch. If there indeed are no existing affected users
besides the KUP users (as you seem to assume) it's a clear case. Pun
intended ;)

As I pointed out (and you cut out), I don't mind doing the revert. I
just want us to do the right things for the right reasons (the ones you
ponted out, Junio).

Michael

  reply	other threads:[~2014-10-22  9:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20141020115943.GA27144@gmail.com>
2014-10-20 15:25 ` Sources for 3.18-rc1 not uploaded Linus Torvalds
2014-10-20 18:28   ` Junio C Hamano
2014-10-20 18:37     ` Konstantin Ryabitsev
2014-10-20 19:43       ` Junio C Hamano
2014-10-20 21:52       ` Greg KH
2014-10-20 22:28   ` brian m. carlson
2014-10-20 23:17     ` Linus Torvalds
2014-10-21  8:08       ` Michael J Gruber
2014-10-21 16:25         ` Linus Torvalds
2014-10-21 17:25           ` David Kastrup
2014-10-21 18:14         ` Junio C Hamano
2014-10-22  9:42           ` Michael J Gruber [this message]
2014-10-23  1:09             ` brian m. carlson
2014-10-26 18:59               ` René Scharfe
2014-10-26 21:15                 ` brian m. carlson
2014-10-27 20:19                 ` Junio C Hamano
2014-10-20 23:44     ` Konstantin Ryabitsev
2014-10-21 18:59       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54477C18.5060806@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=infra-steering@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.