From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/boot/reloc: add memory to clobber list
Date: Wed, 22 Oct 2014 10:58:39 +0100
Message-ID: <54477FCF.7080001@citrix.com>
References: <1413925748-10087-1-git-send-email-daniel.kiper@oracle.com>
	<1413925748-10087-3-git-send-email-daniel.kiper@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Xgsgm-0008Iy-Sb
	for xen-devel@lists.xenproject.org; Wed, 22 Oct 2014 09:58:45 +0000
In-Reply-To: <1413925748-10087-3-git-send-email-daniel.kiper@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel Kiper <daniel.kiper@oracle.com>, xen-devel@lists.xenproject.org
Cc: keir@xen.org, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 21/10/14 22:09, Daniel Kiper wrote:
> Assembly inline in reloc_mbi_struct() clobbers
> memory so tell compiler about that.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  xen/arch/x86/boot/reloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
> index 4609e55..f971920 100644
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -46,7 +46,7 @@ static void *reloc_mbi_struct(void *old, unsigned int bytes)
>      "    mov  %0,%%edi                \n"
>      "    rep  movsb                   \n"
>         : "=&r" (new), "+c" (bytes), "+S" (old)
> -	: : "edx", "edi");
> +	: : "edx", "edi", "memory");
>      return new;
>  }
>