From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] bash: fix linking for static builds with uClibc toolchains
Date: Wed, 22 Oct 2014 11:42:39 +0100 [thread overview]
Message-ID: <54478A1F.1050505@imgtec.com> (raw)
In-Reply-To: <5447894F.7070503@imgtec.com>
Dear Markos Chandras,
On 10/22/2014 11:39 AM, Markos Chandras wrote:
> On 10/22/2014 10:40 AM, Vicente Olivert Riera wrote:
>> bash fails to link for static builds with uClibc toolchains due to
>> getenv redefinitions. This is caused because bash is unable to check if
>> getenv is already defined when cross-compiling, so it defaults to 'yes':
>>
>> configure:14438: WARNING: cannot check getenv redefinition if cross
>> compiling -- defaulting to yes
>>
>> We can avoid this redefinition by passing bash_cv_getenv_redef=no to the
>> configure script.
>>
>> Related:
>> http://lists.gnu.org/archive/html/bug-bash/2012-03/msg00052.html
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/a20/a2007e6dbcfe53e7cd837ae642869ee26376826a/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
> It's best if you write something here ^^^ (below the ---, notes section)
> when you send a new version of the patch so we now what changed from the
> previous version, because it's not always obvious what changed between
> the different versions.
>
> For example
>
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Changes since v3:
> - Added foo
>
> Changes since v2:
> - Added bar
>
> Changes since v1:
> - More foobar
>
Good advice; I'll take it into account for future patches. Thank you!
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
next prev parent reply other threads:[~2014-10-22 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 9:40 [Buildroot] [PATCH v4] bash: fix linking for static builds with uClibc toolchains Vicente Olivert Riera
2014-10-22 10:39 ` Markos Chandras
2014-10-22 10:42 ` Vicente Olivert Riera [this message]
2014-10-22 16:27 ` Arnout Vandecappelle
2014-10-25 10:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54478A1F.1050505@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.