diff for duplicates of <54478AC2.3050009@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 721f010..f6b8a2e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -16,7 +16,7 @@ On 10/21/2014 07:04 PM, Maxime Ripard wrote: >> This has been tested on an olimex a10s-olinuxino-micro, a13-olinuxino, and >> a20-olinuxino-micro. >> ->> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> -- >> Changes in v2: >> -Change devicetree bindings to use a per key subnode, like gpio-keys does @@ -51,13 +51,13 @@ On 10/21/2014 07:04 PM, Maxime Ripard wrote: >> + - label: Descriptive name of the key. >> + - linux,code: Keycode to emit. >> + - channel: Channel this key is attached to, mut be 0 or 1. ->> + - voltage: Voltage in µV at lradc input when this key is pressed. +>> + - voltage: Voltage in ?V at lradc input when this key is pressed. >> + >> +Example: >> + >> +#include <dt-bindings/input/input.h> >> + ->> + lradc: lradc@01c22800 { +>> + lradc: lradc at 01c22800 { >> + compatible = "allwinner,sun4i-lradc-keys"; > > You're still using the old pattern for the compatible here, it should @@ -69,7 +69,7 @@ Will fix for the next version. >> + reg = <0x01c22800 0x100>; >> + interrupts = <31>; >> + vref-supply = <®_vcc3v0>; ->> + button@19 { +>> + button at 19 { > > I guess the node address in centivolts aren't really that common, > maybe in mV instead? @@ -87,25 +87,25 @@ Ack for using mV, will fix for the next version. Will fix for the next version. ->> + button@39 { +>> + button at 39 { >> + label = "Volume Down"; >> + linux,code = <KEY_VOLUMEDOWN>; >> + channel = <0>; >> + voltage = <392644>; >> + }; ->> + button@60 { +>> + button at 60 { >> + label = "Menu"; >> + linux,code = <KEY_MENU>; >> + channel = <0>; >> + voltage = <601151>; >> + }; ->> + button@80 { +>> + button at 80 { >> + label = "Enter"; >> + linux,code = <KEY_ENTER>; >> + channel = <0>; >> + voltage = <795090>; >> + }; ->> + button@98 { +>> + button at 98 { >> + label = "Home"; >> + linux,code = <KEY_HOME>; >> + channel = <0>; @@ -121,15 +121,15 @@ Will fix for the next version. >> F: drivers/net/ethernet/i825xx/sun3* >> >> +SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER ->> +M: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> ->> +L: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +>> +M: Hans de Goede <hdegoede@redhat.com> +>> +L: linux-input at vger.kernel.org >> +S: Maintained >> +F: Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt >> +F: drivers/input/keyboard/sun4i-lradc-keys.c >> + >> SUNDANCE NETWORK DRIVER ->> M: Denis Kirjanov <kda-u1c8ncikuMvVAZt0uhVF+Ni2O/JbrIOy@public.gmane.org> ->> L: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +>> M: Denis Kirjanov <kda@linux-powerpc.org> +>> L: netdev at vger.kernel.org >> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig >> index a3958c6..2d11b44 100644 >> --- a/drivers/input/keyboard/Kconfig @@ -172,7 +172,7 @@ Will fix for the next version. >> +/* >> + * Allwinner sun4i low res adc attached tablet keys driver >> + * ->> + * Copyright (C) 2014 Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> +>> + * Copyright (C) 2014 Hans de Goede <hdegoede@redhat.com> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by @@ -433,7 +433,7 @@ Will fix for the next version. >> +module_platform_driver(sun4i_lradc_driver); >> + >> +MODULE_DESCRIPTION("Allwinner sun4i low res adc attached tablet keys driver"); ->> +MODULE_AUTHOR("Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>"); +>> +MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); >> +MODULE_LICENSE("GPL"); >> -- >> 2.1.0 @@ -446,8 +446,3 @@ Thanks for the review. Regards, Hans - --- -You received this message because you are subscribed to the Google Groups "linux-sunxi" group. -To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 1b1d186..c3fdd4f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,10 @@ "ref\01413879890-7254-1-git-send-email-hdegoede@redhat.com\0" "ref\01413879890-7254-2-git-send-email-hdegoede@redhat.com\0" "ref\020141021170411.GB21108@lukather\0" - "From\0Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 1/4] input: Add new sun4i-lradc-keys driver\0" + "From\0hdegoede@redhat.com (Hans de Goede)\0" + "Subject\0[PATCH v2 1/4] input: Add new sun4i-lradc-keys driver\0" "Date\0Wed, 22 Oct 2014 12:45:22 +0200\0" - "To\0Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" - "Cc\0Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" - linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi,\n" @@ -30,7 +25,7 @@ ">> This has been tested on an olimex a10s-olinuxino-micro, a13-olinuxino, and\n" ">> a20-olinuxino-micro.\n" ">>\n" - ">> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Hans de Goede <hdegoede@redhat.com>\n" ">> --\n" ">> Changes in v2:\n" ">> -Change devicetree bindings to use a per key subnode, like gpio-keys does\n" @@ -65,13 +60,13 @@ ">> +\t- label: Descriptive name of the key.\n" ">> +\t- linux,code: Keycode to emit.\n" ">> +\t- channel: Channel this key is attached to, mut be 0 or 1.\n" - ">> +\t- voltage: Voltage in \302\265V at lradc input when this key is pressed.\n" + ">> +\t- voltage: Voltage in ?V at lradc input when this key is pressed.\n" ">> +\n" ">> +Example:\n" ">> +\n" ">> +#include <dt-bindings/input/input.h>\n" ">> +\n" - ">> +\tlradc: lradc@01c22800 {\n" + ">> +\tlradc: lradc at 01c22800 {\n" ">> +\t\tcompatible = \"allwinner,sun4i-lradc-keys\";\n" "> \n" "> You're still using the old pattern for the compatible here, it should\n" @@ -83,7 +78,7 @@ ">> +\t\treg = <0x01c22800 0x100>;\n" ">> +\t\tinterrupts = <31>;\n" ">> +\t\tvref-supply = <®_vcc3v0>;\n" - ">> +\t\tbutton@19 {\n" + ">> +\t\tbutton at 19 {\n" "> \n" "> I guess the node address in centivolts aren't really that common,\n" "> maybe in mV instead?\n" @@ -101,25 +96,25 @@ "\n" "Will fix for the next version.\n" "\n" - ">> +\t\tbutton@39 {\n" + ">> +\t\tbutton at 39 {\n" ">> +\t\t\tlabel = \"Volume Down\";\n" ">> +\t\t\tlinux,code = <KEY_VOLUMEDOWN>;\n" ">> +\t\t\tchannel = <0>;\n" ">> +\t\t\tvoltage = <392644>;\n" ">> +\t\t};\n" - ">> +\t\tbutton@60 {\n" + ">> +\t\tbutton at 60 {\n" ">> +\t\t\tlabel = \"Menu\";\n" ">> +\t\t\tlinux,code = <KEY_MENU>;\n" ">> +\t\t\tchannel = <0>;\n" ">> +\t\t\tvoltage = <601151>;\n" ">> +\t\t};\n" - ">> +\t\tbutton@80 {\n" + ">> +\t\tbutton at 80 {\n" ">> +\t\t\tlabel = \"Enter\";\n" ">> +\t\t\tlinux,code = <KEY_ENTER>;\n" ">> +\t\t\tchannel = <0>;\n" ">> +\t\t\tvoltage = <795090>;\n" ">> +\t\t};\n" - ">> +\t\tbutton@98 {\n" + ">> +\t\tbutton at 98 {\n" ">> +\t\t\tlabel = \"Home\";\n" ">> +\t\t\tlinux,code = <KEY_HOME>;\n" ">> +\t\t\tchannel = <0>;\n" @@ -135,15 +130,15 @@ ">> F:\tdrivers/net/ethernet/i825xx/sun3*\n" ">> \n" ">> +SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER\n" - ">> +M:\tHans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\n" - ">> +L:\tlinux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + ">> +M:\tHans de Goede <hdegoede@redhat.com>\n" + ">> +L:\tlinux-input at vger.kernel.org\n" ">> +S:\tMaintained\n" ">> +F:\tDocumentation/devicetree/bindings/input/sun4i-lradc-keys.txt\n" ">> +F:\tdrivers/input/keyboard/sun4i-lradc-keys.c\n" ">> +\n" ">> SUNDANCE NETWORK DRIVER\n" - ">> M:\tDenis Kirjanov <kda-u1c8ncikuMvVAZt0uhVF+Ni2O/JbrIOy@public.gmane.org>\n" - ">> L:\tnetdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + ">> M:\tDenis Kirjanov <kda@linux-powerpc.org>\n" + ">> L:\tnetdev at vger.kernel.org\n" ">> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig\n" ">> index a3958c6..2d11b44 100644\n" ">> --- a/drivers/input/keyboard/Kconfig\n" @@ -186,7 +181,7 @@ ">> +/*\n" ">> + * Allwinner sun4i low res adc attached tablet keys driver\n" ">> + *\n" - ">> + * Copyright (C) 2014 Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\n" + ">> + * Copyright (C) 2014 Hans de Goede <hdegoede@redhat.com>\n" ">> + *\n" ">> + * This program is free software; you can redistribute it and/or modify\n" ">> + * it under the terms of the GNU General Public License as published by\n" @@ -447,7 +442,7 @@ ">> +module_platform_driver(sun4i_lradc_driver);\n" ">> +\n" ">> +MODULE_DESCRIPTION(\"Allwinner sun4i low res adc attached tablet keys driver\");\n" - ">> +MODULE_AUTHOR(\"Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\");\n" + ">> +MODULE_AUTHOR(\"Hans de Goede <hdegoede@redhat.com>\");\n" ">> +MODULE_LICENSE(\"GPL\");\n" ">> -- \n" ">> 2.1.0\n" @@ -459,11 +454,6 @@ "\n" "Regards,\n" "\n" - "Hans\n" - "\n" - "-- \n" - "You received this message because you are subscribed to the Google Groups \"linux-sunxi\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org\n" - For more options, visit https://groups.google.com/d/optout. + Hans -13bc7f53c7d550ea06609474ee94eb6b2b900e501f26e69932c2f3ae7dda6ee7 +3bbd6ed7d9b9ade48faf28e1384689b18f582a1a4696e1438fe641d72678060a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.