From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check Date: Wed, 22 Oct 2014 15:43:50 +0400 Message-ID: <54479876.5050202@cogentembedded.com> References: <1413951386-29645-1-git-send-email-varkab@cdac.in> <1413951386-29645-2-git-send-email-varkab@cdac.in> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Varka Bhadram To: Varka Bhadram , netdev@vger.kernel.org Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:57557 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932723AbaJVLnx (ORCPT ); Wed, 22 Oct 2014 07:43:53 -0400 Received: by mail-lb0-f177.google.com with SMTP id w7so2609136lbi.8 for ; Wed, 22 Oct 2014 04:43:51 -0700 (PDT) In-Reply-To: <1413951386-29645-2-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 10/22/2014 8:16 AM, Varka Bhadram wrote: > devm_ioremap_resource checks platform_get_resource() return value. > We can remove the duplicate check here. > Signed-off-by: Varka Bhadram > --- > drivers/net/ethernet/wiznet/w5100.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c > index 0f56b1c..bf195e3 100644 > --- a/drivers/net/ethernet/wiznet/w5100.c > +++ b/drivers/net/ethernet/wiznet/w5100.c > @@ -638,8 +638,7 @@ static int w5100_hw_probe(struct platform_device *pdev) > } > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!mem) > - return -ENXIO; > + > mem_size = resource_size(mem); This would cause a NULL dereference on resource_size() call if 'mem' is NULL. You can't remove the NULL check because of that. > > priv->base = devm_ioremap_resource(&pdev->dev, mem); > WBR, Sergei