From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC 3/3] systemd: xendomains now depends on xen-init-dom0 Date: Wed, 22 Oct 2014 13:11:44 +0100 Message-ID: <54479F00.9010702@citrix.com> References: <1413817309-4884-1-git-send-email-wei.liu2@citrix.com> <1413817309-4884-4-git-send-email-wei.liu2@citrix.com> <1413976485.19198.1.camel@citrix.com> <20141022115155.GA4799@aepfle.de> <20141022120259.GB5087@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141022120259.GB5087@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Olaf Hering Cc: tlviewer@yahoo.com, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Ian Campbell , mcgrof@do-not-panic.com List-Id: xen-devel@lists.xenproject.org On 22/10/14 13:02, Wei Liu wrote: > On Wed, Oct 22, 2014 at 01:51:55PM +0200, Olaf Hering wrote: >> On Wed, Oct 22, Ian Campbell wrote: >> >>> On Mon, 2014-10-20 at 16:01 +0100, Wei Liu wrote: >>>> Signed-off-by: Wei Liu >>> This patch seems to be correct. >>> >>> But, should nothing else depend on this? There doesn't seem to be an >>> umbrella "all the stuff needed for xen" module. Maybe one isn't needed? > I once thought about this but wasn't quite sure. Given that I was quite > new to systemd and we were approaching freeze I focused on fixing this > one bug only. But since you asked, I think a xencommons service is > sensible. > >> Nice that you ask. I was already thinking of a xencommons.service which >> just depends on everything required. Its certainly possible to enable >> each manually. This is what I have in my INSTALL file: >> > Is this suitable for 4.5? Do you can to take over my systemd patch > series and work on it for 4.5? I'm fine with that. > > Wei. This systemd support is brand new for 4.5, and it would be lovely to get it working properly right from the start. >>From a release perspective, the risk is that systemd support will be better/worse given specific patches, but there is no possibility of regressions compared to 4.4 ~Andrew