From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Xgv5X-0003jC-Rg
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:32:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Xgv5R-00057h-1g
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:32:27 -0400
Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:49025)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Xgv5Q-000560-Ql
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:32:20 -0400
Received: by mail-wg0-f44.google.com with SMTP id y10so3578022wgg.3
	for <qemu-devel@nongnu.org>; Wed, 22 Oct 2014 05:32:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5447A3CF.5020304@redhat.com>
Date: Wed, 22 Oct 2014 14:32:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1413968902-24094-1-git-send-email-pbonzini@redhat.com>	<1413968902-24094-2-git-send-email-pbonzini@redhat.com>
	<87iojccnlc.fsf@blackfin.pond.sub.org>
In-Reply-To: <87iojccnlc.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] get_maintainer.pl: exit with status 1
 if no maintainer found
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com


> Thus, the patch makes the script exit with status 1 when none of the
> above output() calls produces output.
> 
> Maybe it exits with status 1 when it fails to produce output?  Obvious
> ouput elsewhere: printing the version (okay),

That exits with 0.

> and a print in get_maintainers().  Can't tell what the latter does.  Hmm.

That is for --sections, and you're right, this is missing:

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index f4fee27..e682d1f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -617,6 +617,7 @@ sub get_maintainers {
 		    print("$line\n");
 		}
 		print("\n");
+		$exit = 0;
 	    }
 	}
     }

Paolo