From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xgv5s-0004C4-Uq
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:32:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xgv5o-0005bd-Hb
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:32:48 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:17564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xgv5o-0005aX-12
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:32:44 -0400
Message-ID: <5447A3E6.3050007@imgtec.com>
Date: Wed, 22 Oct 2014 13:32:38 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <1413366860-7833-1-git-send-email-leon.alrae@imgtec.com>
	<CAFEAcA9pb-YcSZptVejxYR_vNBf83u9D=pft8My9V_Wt+Kaj6g@mail.gmail.com>
	<CAFEAcA-1EaTTJKWaj5c14HJiw09kWcezQPpO1DLFtaL6FXoSKA@mail.gmail.com>
In-Reply-To: <CAFEAcA-1EaTTJKWaj5c14HJiw09kWcezQPpO1DLFtaL6FXoSKA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 00/28] target-mips queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 22/10/2014 13:22, Peter Maydell wrote:
> On 22 October 2014 13:08, Peter Maydell <peter.maydell@linaro.org> wrot=
e:
>> On 15 October 2014 10:53, Leon Alrae <leon.alrae@imgtec.com> wrote:
>>> Hi,
>>>
>>> This pull request has been assembled from pending target-mips patches=
 which
>>> look good to me and received in my opinion sufficient review comments=
. They
>>> were tested mainly in context of MIPS. Please have a look and pull.
>>
>> These all look good -- I have applied the pull request to master.
>=20
> ...but after I did that I noticed these which you should probably
> send a patch to fix:
> target-mips/op_helper.c: In function =E2=80=98bitswap=E2=80=99:
> target-mips/op_helper.c:270: warning: integer constant is too large
> for =E2=80=98long=E2=80=99 type
> target-mips/op_helper.c:271: warning: integer constant is too large
> for =E2=80=98long=E2=80=99 type
> target-mips/op_helper.c:272: warning: integer constant is too large
> for =E2=80=98long=E2=80=99 type
> target-mips/op_helper.c:273: warning: integer constant is too large
> for =E2=80=98long=E2=80=99 type
> target-mips/op_helper.c:274: warning: integer constant is too large
> for =E2=80=98long=E2=80=99 type
> target-mips/op_helper.c:275: warning: integer constant is too large
> for =E2=80=98long=E2=80=99 type
>=20
> 64 bit literal constants need to be suffixed with "ULL", like:
>  0x5555555555555555ULL
> or some of our compilers complain. I think this is the Windows
> build, which we don't currently have set to warnings-as-errors
> due to other longstanding warnings.

Sorry for that, I will send the patch shortly.

Leon