Re: [PATCH v3] xen/arm: dump guest stack even if not the current VCPU

[Julien Grall <julien.grall@linaro.org>]

On 10/22/2014 02:36 PM, Frediano Ziglio wrote:
> From: Frediano Ziglio <frediano.ziglio@huawei.com>
> 
> If show_guest_stack was called from Xen context (for instance hitting
> '0' key on Xen console) get_page_from_gva was not able to get the
> page returning NULL.
> 
> The function get_page_from_gva is used in hot path (see
> arch/arm/guestcopy.c) but always with the current domain. The function
> will be used with another domain than current only when the stack of
> the guest will be dumped. The code added is self-containted.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
> ---
>  xen/arch/arm/p2m.c   | 22 +++++++++++++++++++---
>  xen/arch/arm/traps.c |  2 +-
>  2 files changed, 20 insertions(+), 4 deletions(-)
> 
> Changed from v2:
> - add comment suggested by Julien Grall (I have some doubt about
> removing my initial comments or keep it, I kept it removing the code
> explanation);

By comment I meant after "---", explaining that this patch is bug fix
for Xen 4.5... I didn't ask to modify the commit message. Sorry for not
been clear.

You can give a look to
http://wiki.xen.org/wiki/Xen_Roadmap/4.4#Exception_guidelines_for_after_the_code_freeze.
It's for Xen 4.4 but it also apply for Xen 4.5.

Regards,

-- 
Julien Grall