From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bader Subject: Re: [PATCH v2] xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered Date: Wed, 22 Oct 2014 16:42:35 +0200 Message-ID: <5447C25B.3060701@canonical.com> References: <1412715607-16751-1-git-send-email-boris.ostrovsky@oracle.com> <5436C343.2080102@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6851361785201776476==" Return-path: In-Reply-To: <5436C343.2080102@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , Boris Ostrovsky , konrad.wilk@oracle.com Cc: daniel.kiper@oracle.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6851361785201776476== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5eLOHppLgJLs586REcKrlx6ooPfaFFiiR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5eLOHppLgJLs586REcKrlx6ooPfaFFiiR Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 09.10.2014 19:17, David Vrabel wrote: > On 07/10/14 22:00, Boris Ostrovsky wrote: >> Commit 3dcf63677d4e ("xen/balloon: cancel ballooning if adding new >> memory failed") makes reserve_additional_memory() return BP_ECANCELED >> when an error is encountered. This error, however, is ignored by the >> caller (balloon_process()) since it is overwritten by subsequent call >> to update_schedule(). This results in continuous attempts to add more >> memory, all of which are likely to fail again. >> >> We should stop trying to schedule next iteration of ballooning when >> the current one has failed. >=20 > What triggers this bug? I could never work out what it was. >=20 > Applied to stable/for-linus-3.18 I just checked in the kernel upstream repo and cannot find this but I bel= ieve the initial pull was already made. Or was there a revert that I missed? -Stefan >=20 > David >=20 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >=20 --5eLOHppLgJLs586REcKrlx6ooPfaFFiiR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJUR8JvAAoJEOhnXe7L7s6jtAoQAM6QkvkGeQOL1+TfJzXnnYpu Yrwg/vHGtPB0GgVgCSvhI73S34S+hr+9s+eYkStus43OYkhKl9UwM4/lb1hlJF6+ 4pIMr1M0+v9dSnsN5bdB08zdW7PpWGDqiorl1GIltGx5+O/dWRNvZ28cqMuQH1qF Sb5A8bm1eKI8FiksOrYgYN1/h9SJzq8Oz24xgV5nLoJ8O+kejPcQH1hp1LrFJX3e Y+BHnwsRKBfpWQ0MYwFo/bHQinelpIQEj4UOoF3GtQoyYYvAowk6I+Bs2vN6w4IK glfcFAUM2HzQY+Z2A/l/tBguOUB4RZIz50DJM8WDOLcAvonviLZJ5c8PuicAH97w NcGVLU7GtPoxGHUdJB28IctOjz5mSbpvM9RGJSh1lF6m2SF5qnxkQEaVdntJsY7K ik/7puw/WjKO5T5YOfrYj4fLP40mWJ295/nOAy+fZbzmEnv/vBJW6jF63kRCAzxn gZ1DiTtOh24uNl/eg/0u8gvr9V9dxsRECm1U8fMRiHyL4hAM3oY90nuBR0Me1Vvl BModj8i58qaWOMBDNuAgcpAVfnFMaCAOZfrVDFu/HtAZrRcrj4bIy1OX2tGgjsFG lcTj07HjwuDDXIE13H0YcuQrO0buQmsICtEU9Ys/Fds1Xc+E1ErAE//+LJSQ6zp2 ffs/g7RdzeB7/tDEAkVS =i+G7 -----END PGP SIGNATURE----- --5eLOHppLgJLs586REcKrlx6ooPfaFFiiR-- --===============6851361785201776476== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6851361785201776476==--