From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v2] xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered Date: Wed, 22 Oct 2014 15:52:51 +0100 Message-ID: <5447C4C3.4010101@citrix.com> References: <1412715607-16751-1-git-send-email-boris.ostrovsky@oracle.com> <5436C343.2080102@citrix.com> <5447C25B.3060701@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5447C25B.3060701@canonical.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefan Bader , Boris Ostrovsky , konrad.wilk@oracle.com Cc: daniel.kiper@oracle.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 22/10/14 15:42, Stefan Bader wrote: > On 09.10.2014 19:17, David Vrabel wrote: >> On 07/10/14 22:00, Boris Ostrovsky wrote: >>> Commit 3dcf63677d4e ("xen/balloon: cancel ballooning if adding new >>> memory failed") makes reserve_additional_memory() return BP_ECANCELED >>> when an error is encountered. This error, however, is ignored by the >>> caller (balloon_process()) since it is overwritten by subsequent call >>> to update_schedule(). This results in continuous attempts to add more >>> memory, all of which are likely to fail again. >>> >>> We should stop trying to schedule next iteration of ballooning when >>> the current one has failed. >> >> What triggers this bug? I could never work out what it was. >> >> Applied to stable/for-linus-3.18 > > I just checked in the kernel upstream repo and cannot find this but I believe > the initial pull was already made. Or was there a revert that I missed? I've not sent the pull request for it yet. David