From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 720CAE007EB; Wed, 22 Oct 2014 10:50:27 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 2569CE00799 for ; Wed, 22 Oct 2014 10:50:14 -0700 (PDT) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id 298DCF811E2; Wed, 22 Oct 2014 11:50:14 -0600 (MDT) Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 0FA49F811E2; Wed, 22 Oct 2014 11:50:13 -0600 (MDT) Message-ID: <5447EE79.6040504@mlbassoc.com> Date: Wed, 22 Oct 2014 11:50:49 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Otavio Salvador , Neena Busireddy References: <1413893540-22349-1-git-send-email-gary@mlbassoc.com> <6aa9512ed41b432b80428fbd70ce90b5@BLUPR03MB471.namprd03.prod.outlook.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 17:50:27 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2014-10-22 09:36, Otavio Salvador wrote: > On Wed, Oct 22, 2014 at 12:38 PM, Neena Busireddy > wrote: >> Hi Otavio, >> >> On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas wrote: >>> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags >>> which were set by the main recipe to be lost, e.g. "x11". The flags >>> which are being set by these lines are correctly set in the main >>> recipe, so this change fixes the errant behaviour with no other side effects. >>> >>> Signed-off-by: Gary Thomas >> >> Can you review this patch and comment? >> >> Looks like you added the PACKAGECONFIG for directfb in cairo.bbappend. I have no idea >> why it was added. However, that patch looks good to me. > > That means Gary one or the way it was before? > Setting PACKAGECONFIG directly in the .bbappend is clearly wrong as it erases any settings made by the main recipe which is doing the same setting any way. Hence my patch. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------