From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh0fT-0006JV-2a for qemu-devel@nongnu.org; Wed, 22 Oct 2014 14:29:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xh0fO-0008LW-Ky for qemu-devel@nongnu.org; Wed, 22 Oct 2014 14:29:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh0fO-0008LK-Be for qemu-devel@nongnu.org; Wed, 22 Oct 2014 14:29:50 -0400 Message-ID: <5447F798.1060609@redhat.com> Date: Wed, 22 Oct 2014 12:29:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1413984120-21830-1-git-send-email-pl@kamp.de> <1413984120-21830-4-git-send-email-pl@kamp.de> In-Reply-To: <1413984120-21830-4-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G6Ob1XlFbSlfvUERlVCVQFAPvSggfRD7g" Subject: Re: [Qemu-devel] [PATCHv2 3/6] block: add a knob to disable multiwrite_merge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G6Ob1XlFbSlfvUERlVCVQFAPvSggfRD7g Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/22/2014 07:21 AM, Peter Lieven wrote: > The block layer silently merges write requests since > commit 40b4f539. This patch adds a knob to disable > this feature as there has been some discussion lately > if multiwrite is a good idea at all and as it falsifies > benchmarks. >=20 > Signed-off-by: Peter Lieven > Reviewed-by: Max Reitz >=20 > Signed-off-by: Peter Lieven Is the double s-o-b intentional? > +++ b/hmp.c > @@ -348,6 +348,10 @@ void hmp_info_block(Monitor *mon, const QDict *qdi= ct) > BlockdevDetectZeroesOptions_lookup[info->va= lue->inserted->detect_zeroes]); > } > =20 > + if (!info->value->inserted->write_merging) { > + monitor_printf(mon, " Write Merging: off\n"); > + } Is it also worth printing something if write merging is enabled? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --G6Ob1XlFbSlfvUERlVCVQFAPvSggfRD7g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUR/eYAAoJEKeha0olJ0NqfPoH/Az1COKEt053Tlmuis+3IQuo Bslvl1/j+zFZMsD/i9MDTMncBUSGnQmK2OkVfQqBkVXX9y23QxvJEwhAV5BnAGJV dCHijQiTRuWSr0gsrsydFmMvzuokwyOldp64uKadP7eWtRcxp67Rf5OoZoIbnnfi OFr/CRdqZjXf6lcxVrg3HU/8042xapFJS9hhVIZg0SotPyh3ZVt5x7fOgQKdC+r2 xhxIlIM7rK4bsL4vRtVBmKKhw6bmi+x9sMjs8bZmlqZQ0uch1P68HRBbkQr/vDi7 Co1MPAvRI1E16Hnx0zBQ1pwHGg6YoZ8beibHRWnQwNfJPPmNIU3fxBYp+TpOH+4= =mFDO -----END PGP SIGNATURE----- --G6Ob1XlFbSlfvUERlVCVQFAPvSggfRD7g--