From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@primarydata.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] nfsd4: fix response size estimation for OP_SEQUENCE
Date: Wed, 22 Oct 2014 15:33:13 -0400 [thread overview]
Message-ID: <54480679.70501@Netapp.com> (raw)
In-Reply-To: <20141022192258.GB5552@fieldses.org>
On 10/22/14 15:22, J. Bruce Fields wrote:
> On Tue, Oct 21, 2014 at 09:14:06AM -0400, J. Bruce Fields wrote:
>> Also my tests are failing due to an unrelated crash in 18-rc1 which I
>> want to track down before sending this in.
>
> There are two bugs:
>
> - the client is sending SEEK over minorversion 1.
> - this sometimes causes the server to crash.
>
> I'm testing a fix for the latter.
>
> On the former: looks like if 4.2 support is built in, then llseek is set
> to nfs4_file_llseek, which unconditionally calls nfs42_proc_llseek().
>
> Does nfs4_file_llseek need an explicit minorversion check, or should it
> be handled some other way?
The client should be checking for CAP_SEEK, which should only be set on NFS v4.2. I'll look into this!
>
> --b.
>
next prev parent reply other threads:[~2014-10-22 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 21:24 [PATCH] nfsd4: fix response size estimation for OP_SEQUENCE J. Bruce Fields
2014-10-21 10:36 ` Christoph Hellwig
2014-10-21 13:14 ` J. Bruce Fields
2014-10-22 19:22 ` J. Bruce Fields
2014-10-22 19:33 ` Anna Schumaker [this message]
2014-10-22 19:42 ` J. Bruce Fields
2014-10-22 20:12 ` Tom Haynes
2014-10-23 7:34 ` Christoph Hellwig
2014-10-22 19:49 ` [PATCH] nfsd4: fix crash on unknown operation number J. Bruce Fields
2014-10-23 11:54 ` [PATCH] nfsd4: fix response size estimation for OP_SEQUENCE Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54480679.70501@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.