From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh6Ka-0007Ux-6q for qemu-devel@nongnu.org; Wed, 22 Oct 2014 20:32:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xh6KV-0001CM-Cn for qemu-devel@nongnu.org; Wed, 22 Oct 2014 20:32:44 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:61938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh6KU-0001Bz-Rv for qemu-devel@nongnu.org; Wed, 22 Oct 2014 20:32:39 -0400 Message-ID: <54484C88.3070305@huawei.com> Date: Thu, 23 Oct 2014 08:32:08 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1413535838-11000-1-git-send-email-zhang.zhanghailiang@huawei.com> <5440DB35.9020507@huawei.com> In-Reply-To: <5440DB35.9020507@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: hutao@cn.fujitsu.com, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, pbonzini@redhat.com, imammedo@redhat.com Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: > On 2014/10/17 16:50, zhanghailiang wrote: > >> When do memory hotplug, if there is numa node, we should add >> the memory size to the corresponding node memory size. >> >> For now, it mainly affects the result of hmp command "info numa". >> >> Reviewed-by: Igor Mammedov >> Signed-off-by: zhanghailiang >> --- >> v6: >> - remove unnecessary 'di' variable (GongLei) >> v5: >> - reword the subject (Igor Mammedov) >> - turn query_numa_node_mem to void (Igor Mammedov) >> v4: >> - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) >> - rewrite numa_stat_memory_devices and this will also fix compile error for >> targets that don't support memory hotplug >> v3: >> - cold-plugged memory should not be excluded (Igor Mammedov) >> v2: >> - Don't modify the numa_info.node_mem directly when treating hotplug memory, >> fix the "info numa" instead (Igor Mammedov) >> >> Thanks for review!;) >> --- >> >> include/sysemu/sysemu.h | 1 + >> monitor.c | 6 +++++- >> numa.c | 38 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 44 insertions(+), 1 deletion(-) >> > > Reviewed-by: Gonglei > > Best regards, > -Gonglei > > > . >