All of lore.kernel.org
 help / color / mirror / Atom feed
From: wenzong fan <wenzong.fan@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] lsof: fix LSOF_CCV in version.h
Date: Thu, 23 Oct 2014 14:27:34 +0800	[thread overview]
Message-ID: <54489FD6.4010804@windriver.com> (raw)
In-Reply-To: <CAJTo0LbMFw8TiZkn=nchFCmbA9ZgZhW2+yaQnhg99=g4i3n2=w@mail.gmail.com>

On 10/23/2014 04:03 AM, Burton, Ross wrote:
>
> On 22 October 2014 04:23, <wenzong.fan@windriver.com
> <mailto:wenzong.fan@windriver.com>> wrote:
>
>     +-      @echo '#define  LSOF_CCV        "${CCV}"' >> version.h
>     ++      @LSOF_CCV=`${CC} -v 2>&1 | sed -n 's/.*version \(.*\)/\1/p'` &&\
>     ++      echo "#define   LSOF_CCV        \"${LSOF_CCV}\"" >> version.h
>
>
> It seems that a better (and importantly, upstreamable) fix would be to
> pass LSOF_CC correctly to ./Configure instead of overriding in
> do_compile(), and change the LSOF_CCV assignment to run LSOF_CC if _CCV
> isn't already set.

Ok, I'll redo the patch and send V2.

Thanks
Wenzong

>
> (My general approach here is spend a little more time getting a fix
> upstreamed so that we're not fixing our patch every few months)
>
> Ross
>


      reply	other threads:[~2014-10-23  6:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22  3:23 [PATCH 0/1] lsof: fix LSOF_CCV in version.h wenzong.fan
2014-10-22  3:23 ` [PATCH 1/1] " wenzong.fan
2014-10-22 20:03   ` Burton, Ross
2014-10-23  6:27     ` wenzong fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54489FD6.4010804@windriver.com \
    --to=wenzong.fan@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.