From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhCX3-0002yv-Ur for qemu-devel@nongnu.org; Thu, 23 Oct 2014 03:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhCWy-00030X-V0 for qemu-devel@nongnu.org; Thu, 23 Oct 2014 03:10:01 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:55044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhCWy-00030K-O5 for qemu-devel@nongnu.org; Thu, 23 Oct 2014 03:09:56 -0400 Message-ID: <5448A9C3.1010804@msgid.tls.msk.ru> Date: Thu, 23 Oct 2014 11:09:55 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1414042783-2180-1-git-send-email-arei.gonglei@huawei.com> <1414042783-2180-2-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1414042783-2180-2-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, kraxel@redhat.com, peter.huangpeng@huawei.com On 10/23/2014 09:39 AM, arei.gonglei@huawei.com wrote: > From: Gonglei > > vnc_display_close() is called in vnc_display_open(). > And in this moment, the ds variable is initilized > at vnc_display_init(). Calling vnc_display_close() > is superfluous. Maybe the intent was to be able to open/close new vnc displays in the future? I think I've seen patches to allow several vnc displays at once... Thanks, /mjt