Re: [Qemu-devel] [PATCH 3/3] vnc: remove superfluous DisplayState *ds parameter

[Gonglei <arei.gonglei@huawei.com>]

On 2014/10/23 15:09, Michael Tokarev wrote:

> On 10/23/2014 09:39 AM, arei.gonglei@huawei.com wrote:
> []
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -4318,7 +4318,7 @@ int main(int argc, char **argv, char **envp)
>>      if (vnc_display) {
>>          Error *local_err = NULL;
>>          vnc_display_init(ds);
>> -        vnc_display_open(ds, vnc_display, &local_err);
>> +        vnc_display_open(vnc_display, &local_err);
>>          if (local_err != NULL) {
> 
> So why do you make the two display-initing functions assymetric?
> Why one of them expects a `ds' argument (it is called from just
> one place, and this is THE place), while you remove this arg from
> another?
> 
> Maybe we should remove the ds arg from both (and clean up the
> variable in question from main() too -- why it is declared at
> the start of main() anyway, instead of this very place like
> local_err is?)
> 
Hmm. I notice Gerd's patch had done this clean work:

http://lists.nongnu.org/archive/html/qemu-devel/2014-10/msg01618.html

Maybe I should drop this patch. Thanks.

Best regards,
-Gonglei