All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: Add I2C support to SoCFPGA
Date: Thu, 23 Oct 2014 09:55:25 +0200	[thread overview]
Message-ID: <5448B46D.1090203@denx.de> (raw)
In-Reply-To: <544600D6.9060703@denx.de>

Hi Marek, Hi Heiko!

On 21.10.2014 08:44, Heiko Schocher wrote:
>>>   /*
>>> + * I2C support
>>> + */
>>> +#define CONFIG_HARD_I2C
>
> No ... do not add this define please.
>
>>> +#define CONFIG_DW_I2C
>>> +#define CONFIG_I2C_MULTI_BUS
>>
>> I presume this should be converted to CONFIG_SYS_I2C framework instead
>> of using
>> this I2C multibus horror, no?
>
> ... Yes, please!
>
> Which i2c driver does socfpga use? If it is the
> "drivers/i2c/designware_i2c.c"
> driver, please convert it to the "CONFIG_SYS_I2C" framework.

Yes. Its the designware driver.

I wanted to make this I2C support for SoCFPGA least intrusive. But I see 
your point. Moving this driver to the new I2C framework makes sense.

> You may also take a look into Simons RFC patches, which introduce
> DM model:
> http://lists.denx.de/pipermail/u-boot/2014-October/191497.html

This seems a bit too early for me.

I'll try to find some time to move to the "CONFIG_SYS_I2C" framework...

Thanks,
Stefan

  reply	other threads:[~2014-10-23  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20  6:45 [U-Boot] [PATCH] arm: socfpga: Add I2C support to SoCFPGA Stefan Roese
2014-10-20 14:46 ` Marek Vasut
2014-10-21  6:44   ` Heiko Schocher
2014-10-23  7:55     ` Stefan Roese [this message]
2014-10-23  8:47       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5448B46D.1090203@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.