From: Gonglei <arei.gonglei@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open()
Date: Thu, 23 Oct 2014 16:05:46 +0800 [thread overview]
Message-ID: <5448B6DA.5010702@huawei.com> (raw)
In-Reply-To: <1414051026.30724.4.camel@nilsson.home.kraxel.org>
On 2014/10/23 15:57, Gerd Hoffmann wrote:
> On Do, 2014-10-23 at 14:33 +0800, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> When using qmp change vnc interface, will leak fd
>> of vs->lsock and vs->lwebsock (if configed). Close
>> them before: re-evaluate.
>
> Ah, the file handles are leaked because you dropped the
> vnc_display_close() call. Don't do that then ...
>
Oops, understand. Sorry for the noise :(
What's your suggestion about the problem described in cover-letter? Gerd
Best regards,
-Gonglei
prev parent reply other threads:[~2014-10-23 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 6:33 [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open() arei.gonglei
2014-10-23 7:52 ` Gerd Hoffmann
2014-10-23 7:57 ` Gerd Hoffmann
2014-10-23 8:05 ` Gonglei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5448B6DA.5010702@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.