From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XhDcX-0001Hs-53
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 04:19:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XhDcS-0001ZT-B6
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 04:19:45 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:50504)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XhDcQ-0001YW-SA
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 04:19:40 -0400
Message-ID: <5448BA00.4010608@huawei.com>
Date: Thu, 23 Oct 2014 16:19:12 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1414042783-2180-1-git-send-email-arei.gonglei@huawei.com>
	<1414051702.30724.6.camel@nilsson.home.kraxel.org>
In-Reply-To: <1414051702.30724.6.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] vnc: trivial problem and memory leak
	fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>

On 2014/10/23 16:08, Gerd Hoffmann wrote:

> On Do, 2014-10-23 at 13:39 +0800, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Beside those problems, I also found another issue, see below pls.
>>
>> Qemu command line:
>> $ ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive file=/home/redhat.img,if=none,id=drive-ide0-0-0 -device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 -drive file=/mnt/sdb/gonglei/iso/rhel-server-7.0-x86_64-dvd.iso,if=none,id=drive-ide0-0-1 -device ide-cd,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1,bootindex=4 -qmp unix:/tmp/qmp,server,nowait -monitor stdio -vnc 0.0.0.0:10,password,sasl
>> QEMU 2.1.50 monitor - type 'help' for more information
>> (qemu) change vnc password 123
>> (qemu) change vnc abc
>> error parsing address 'abc'     ---> an intended result because of I set a invalid value 'abc'
>> (qemu) change vnc password 456
>> If you want use passwords please enable password auth using '-vnc ${dpy},password'.Could not set password  --> Oops. I shouldn't get this output.
>> (qemu) 
>>
>>
>> Though we call qmp_change_vnc() failed, the content of global variable vnc_display
>> still will change, such as 'vs->auth = VNC_AUTH_NONE' now. I think this is not
>> reasonable, but I have not good idea to address this issue.
> 
> I think the current behavior is fine.  Better be on the safe side (no
> connects possible) in case "change vnc $display" failed.  You can fix
> that using "change vnc 0.0.0.0:10,password,sasl"
> 

Yes. we can do this. But is it reasonable that an API return false,
but its content changed?

Best regards,
-Gonglei