All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
Date: Thu, 23 Oct 2014 10:52:23 +0200	[thread overview]
Message-ID: <5448C1C7.4070200@redhat.com> (raw)
In-Reply-To: <20141022192400.GG25506@bill-the-cat>

Hi Tom,

On 10/22/2014 09:24 PM, Tom Rini wrote:
> On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote:
> 
>> Old kernels cannot handle booting in non-secure (hyp) mode, so when
>> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>>
>> Note that whether to booting secure or non-secure can always be overriden
>> using the bootm_boot_mode environment variable.
> 
> This belongs in Kconfig.  If you want to make it really optional all the
> same, make modifying it depend on CONFIG_EXPERT too.

I understand where your coming from, but the problem is that
CONFIG_ARMV7_SEC_BY_DEFAULT as a Kconfig option should depend on
CONFIG_ARMV7_VIRT or CONFIG_ARMV7_NONSEC, which depend on
CONFIG_ARMV7_PSCI / CONFIG_ARMV7_PSCI_NR_CPUS and
CONFIG_ARMV7_SECURE_BASE, all of which are currently set
through include/configs/foo.h.

I know that the plan is to move all of these to Kconfig eventually,
but there still is a lot of figuring out how that exactly should be
done, and as such I believe that it is best to set
CONFIG_ARMV7_SEC_BY_DEFAULT the "old-fashioned" way for now.

Regards,

Hans

  reply	other threads:[~2014-10-23  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 13:45 [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set Hans de Goede
2014-10-22 18:57 ` Ian Campbell
2014-10-23  8:52   ` Hans de Goede
2014-10-22 19:24 ` Tom Rini
2014-10-23  8:52   ` Hans de Goede [this message]
2014-10-23 13:10     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5448C1C7.4070200@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.