From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH] drm/panel: ld9040: Update calls to gpiod_get*() Date: Thu, 23 Oct 2014 11:45:46 +0200 Message-ID: <5448CE4A.6010207@samsung.com> References: <1414052177-19978-1-git-send-email-acourbot@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id 902C46E44D for ; Thu, 23 Oct 2014 02:45:50 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NDW003RT5WYZT50@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 23 Oct 2014 10:48:34 +0100 (BST) In-reply-to: <1414052177-19978-1-git-send-email-acourbot@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandre Courbot , Thierry Reding Cc: gnurou@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 10/23/2014 10:16 AM, Alexandre Courbot wrote: > Add the new flags argument to calls of (devm_)gpiod_get*() and > remove any direction setting code afterwards. > > Currently both forms (with or without the flags argument) > are valid thanks to transitional macros in > . These macros will be removed once > all consumers are updated and the flags argument will become > compulsary. > > Signed-off-by: Alexandre Courbot It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this: Acked-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c > index 42ac67b21e9f..dd1d3f2e624e 100644 > --- a/drivers/gpu/drm/panel/panel-ld9040.c > +++ b/drivers/gpu/drm/panel/panel-ld9040.c > @@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi) > if (ret < 0) > return ret; > > - ctx->reset_gpio = devm_gpiod_get(dev, "reset"); > + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); > if (IS_ERR(ctx->reset_gpio)) { > dev_err(dev, "cannot get reset-gpios %ld\n", > PTR_ERR(ctx->reset_gpio)); > return PTR_ERR(ctx->reset_gpio); > } > - ret = gpiod_direction_output(ctx->reset_gpio, 1); > - if (ret < 0) { > - dev_err(dev, "cannot configure reset-gpios %d\n", ret); > - return ret; > - } > > spi->bits_per_word = 9; > ret = spi_setup(spi); >