From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XhFIl-0005Td-HT
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 06:07:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XhFIf-0003ek-9T
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 06:07:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XhFIf-0003dd-2M
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 06:07:21 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9NA7KoV023691
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2014 06:07:20 -0400
Message-ID: <5448D356.60006@redhat.com>
Date: Thu, 23 Oct 2014 12:07:18 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1413982283-10186-1-git-send-email-mreitz@redhat.com>
	<1413982283-10186-7-git-send-email-mreitz@redhat.com>
	<20141023100632.GI3522@noname.redhat.com>
In-Reply-To: <20141023100632.GI3522@noname.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test
 in 040 and 041
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-10-23 at 12:06, Kevin Wolf wrote:
> Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
>> As of a follow-up patch to this one, the length of a mirror block job
>> will no longer directly depend on the size of the block device;
>> therefore, drop these checks from this test. Instead, just check whether
>> the final offset equals the block job length.
>>
>> As 041 uses the wait_until_completed function from iotests.py, the same
>> applies there as well which in turn affects tests 030, 055 and 056. On
>> the other hand, a block job's length does not have to be related to the
>> length of the image file in the first place, so that check was
>> questionable anyway.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
> Possibly a result of rebasing over a long time, but 041 still has some
> checks of len left after this patch.

Very likely, yes. I'll fix it.

Max