From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-xen-4-5 v3] xen/arm: dump guest stack even if not the current VCPU Date: Thu, 23 Oct 2014 12:56:03 +0100 Message-ID: <5448ECD3.7090001@linaro.org> References: <1414063877.1140.0.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1414063877.1140.0.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Frediano Ziglio Cc: Stefano Stabellini , xen-devel@lists.xen.org, Tim Deegan List-Id: xen-devel@lists.xenproject.org On 10/23/2014 12:31 PM, Ian Campbell wrote: > On Thu, 2014-10-23 at 09:46 +0100, Frediano Ziglio wrote: >> From: Frediano Ziglio >> >> If show_guest_stack was called from Xen context (for instance hitting >> '0' key on Xen console) get_page_from_gva was not able to get the >> page returning NULL. >> Detecting different domain and changing VTTBR register make >> get_page_from_gva works for different domains. >> >> Signed-off-by: Frediano Ziglio > > Acked + applied (since Konrad said ok in v2). > >> - collapse change in a single if to improve performances. > > Not 100% keen on the duplicated call to gvirt_to_maddr, but it'll do. I think having two if with gvirt_to_maddr in the middle would have been fine. My main concern was disabling the IRQ before taking the lock. Anyway, I plan to send a patch for 4.6 to improve this function. The p2m is taken for a long time for nothing. Regards, -- Julien Grall