From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.5] tools/libxl: Fix building against
 libxl for LIBXL_API_VERSION < 0x040500
Date: Thu, 23 Oct 2014 13:19:23 +0100
Message-ID: <5448F24B.7090606@citrix.com>
References: <1413536179-21129-1-git-send-email-andrew.cooper3@citrix.com>		<21568.63163.931343.323308@mariner.uk.xensource.com>		<5440F722.4090209@citrix.com>		<21568.63504.42838.728406@mariner.uk.xensource.com>	
	<21568.63641.51091.765530@mariner.uk.xensource.com>	
	<54412582.8050203@citrix.com>
	<1413816369.13796.17.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1413816369.13796.17.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 20/10/14 15:46, Ian Campbell wrote:
> On Fri, 2014-10-17 at 15:19 +0100, Andrew Cooper wrote:
>> On 17/10/14 12:08, Ian Jackson wrote:
>>> Ian Jackson writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"):
>>>> Andrew Cooper writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"):
>>>>> On 17/10/14 12:00, Ian Jackson wrote:
>>>>>> I think this was intended to read
>>>>>>   #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
>>>>>> but should in fact read
>>>>>>   #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src))
>>> Having checked the rules, for C++ this might conceivably have to be
>>>     #define libxl_uuid_copy(dst, src) (libxl_uuid_copy(NULL, (dst), (src)))
>>>
>>> Ian.
>> Fundamentally, I am not really fussed how this is fixed, although I have
>> confirmed my patch fixes the libvirt build in the XenServer branch I am
>> attempting to test Xen-4.5 under.
> Ian, are you happy with that or do you want to (ask Andy to) resubmit
> with the #define?
>
> Ian.
>

Ping (regarding question)? Whichever fix gets used eventually. this
really needs to get in before the release candidate is cut.

~Andrew