From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] EFI: constify a few table pointers
Date: Thu, 23 Oct 2014 15:48:28 +0100 [thread overview]
Message-ID: <5449153C.4090303@citrix.com> (raw)
In-Reply-To: <544922AD0200007800041775@mail.emea.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1962 bytes --]
On 23/10/14 14:45, Jan Beulich wrote:
> We shouldn't (and don't) modify any of these tables.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -75,7 +75,7 @@ static size_t wstrlen(const CHAR16 * s);
> static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz);
> static bool_t match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2);
>
> -static EFI_BOOT_SERVICES *__initdata efi_bs;
> +static const EFI_BOOT_SERVICES *__initdata efi_bs;
> static EFI_HANDLE __initdata efi_ih;
>
> static SIMPLE_TEXT_OUTPUT_INTERFACE *__initdata StdOut;
> --- a/xen/common/efi/efi.h
> +++ b/xen/common/efi/efi.h
> @@ -18,12 +18,12 @@ struct efi_pci_rom {
> };
>
> extern unsigned int efi_num_ct;
> -extern EFI_CONFIGURATION_TABLE *efi_ct;
> +extern const EFI_CONFIGURATION_TABLE *efi_ct;
>
> extern unsigned int efi_version, efi_fw_revision;
> extern const CHAR16 *efi_fw_vendor;
>
> -extern EFI_RUNTIME_SERVICES *efi_rs;
> +extern const EFI_RUNTIME_SERVICES *efi_rs;
>
> extern UINTN efi_memmap_size, efi_mdesc_size;
> extern void *efi_memmap;
> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -21,13 +21,13 @@ const bool_t efi_enabled = 1;
> #endif
>
> unsigned int __read_mostly efi_num_ct;
> -EFI_CONFIGURATION_TABLE *__read_mostly efi_ct;
> +const EFI_CONFIGURATION_TABLE *__read_mostly efi_ct;
>
> unsigned int __read_mostly efi_version;
> unsigned int __read_mostly efi_fw_revision;
> const CHAR16 *__read_mostly efi_fw_vendor;
>
> -EFI_RUNTIME_SERVICES *__read_mostly efi_rs;
> +const EFI_RUNTIME_SERVICES *__read_mostly efi_rs;
> #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */
> static DEFINE_SPINLOCK(efi_rs_lock);
> #endif
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2786 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-10-23 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 13:38 [PATCH 0/3] EFI: runtime services related improvements Jan Beulich
2014-10-23 13:44 ` [PATCH 1/3] x86: tolerate running on EFI runtime services page tables in map_domain_page() Jan Beulich
2014-10-23 13:57 ` Andrew Cooper
2014-10-23 15:18 ` Jan Beulich
2014-10-24 9:52 ` Andrew Cooper
2014-10-23 13:45 ` [PATCH 2/3] EFI: allow to suppress the use of runtime services Jan Beulich
2014-10-23 14:47 ` Andrew Cooper
2014-10-23 13:45 ` [PATCH 3/3] EFI: constify a few table pointers Jan Beulich
2014-10-23 14:48 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5449153C.4090303@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.