From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Kirill Batuzov" <batuzovk@ispras.ru>,
maria.klimushenkova@ispras.ru,
"Pavel Dovgalyuk" <Pavel.Dovgaluk@ispras.ru>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Денис Дмитриев" <zealot351@gmail.com>,
"Leon Alrae" <leon.alrae@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH] arm: fix TB alignment check
Date: Thu, 23 Oct 2014 09:33:27 -0700 [thread overview]
Message-ID: <54492DD7.90805@twiddle.net> (raw)
In-Reply-To: <CAFEAcA--ZGExNsKAK7Cp8rU_fViECuROQnqR8XzK=0CGsQudhg@mail.gmail.com>
On 10/23/2014 09:25 AM, Peter Maydell wrote:
> On 23 October 2014 17:15, Richard Henderson <rth@twiddle.net> wrote:
>> [1] Why 32 when the maximum insn size is more like 15 bytes, I don't know. But
>> it likely doesn't matter since I'd expect such large TB's to fill up the opcode
>> buffer first. There would have to be a lot of nops on that page.
>
> Do we actually correctly GPF if the guest hands us an instruction
> with a huge long set of prefix bytes? I can't see anything obviously
> in the code that catches this case...
No, I don't think we check for that at all.
r~
next prev parent reply other threads:[~2014-10-23 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 12:14 [Qemu-devel] [PATCH] arm: fix TB alignment check Pavel Dovgalyuk
2014-10-23 13:18 ` Peter Maydell
2014-10-23 13:42 ` Laurent Desnogues
2014-10-23 16:15 ` Richard Henderson
2014-10-23 16:25 ` Peter Maydell
2014-10-23 16:33 ` Richard Henderson [this message]
2014-10-24 5:24 ` Pavel Dovgaluk
2014-10-24 16:08 ` Leon Alrae
2015-09-19 10:00 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54492DD7.90805@twiddle.net \
--to=rth@twiddle.net \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=leon.alrae@imgtec.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.