From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Freitas Subject: Re: [PATCH for 4.5 v7 1/1] Add mmio_hole_size Date: Thu, 23 Oct 2014 09:57:25 -0700 Message-ID: <54493375.5040100@ihonk.com> References: <1413204679-7345-1-git-send-email-dslutz@verizon.com> <1413204679-7345-2-git-send-email-dslutz@verizon.com> <1413814677.13796.10.camel@citrix.com> <54458621.3080102@terremark.com> <1413877953.20604.19.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7575040096461511911==" Return-path: In-Reply-To: <1413877953.20604.19.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Don Slutz Cc: Boris Ostrovsky , xen-devel@lists.xen.org, Ian Jackson , Jan Beulich , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============7575040096461511911== Content-Type: multipart/alternative; boundary="------------030907070207040307040104" This is a multi-part message in MIME format. --------------030907070207040307040104 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 10/21/2014 0:52, Ian Campbell wrote: > > On Mon, 2014-10-20 at 18:01 -0400, Don Slutz wrote: > > So I do not know which way to go here. > > I'm not sure why the fact that HVM_BELOW_4G_MMIO_LENGTH happens to be > 256M right now should be of interest to the casual reader of this code. > They can always lookup the #define. > > Putting the value of a define next to every use of it somewhat defeats > the purpose of having a define. Hi guys, How's this looking for 4.5? :-D Steve --------------030907070207040307040104 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit
On 10/21/2014 0:52, Ian Campbell wrote:
On Mon, 2014-10-20 at 18:01 -0400, Don Slutz wrote:

So I do not know which way to go here.

I'm not sure why the fact that HVM_BELOW_4G_MMIO_LENGTH happens to be
256M right now should be of interest to the casual reader of this code.
They can always lookup the #define.

Putting the value of a define next to every use of it somewhat defeats
the purpose of having a define.

Hi guys,

How's this looking for 4.5? :-D

Steve
--------------030907070207040307040104-- --===============7575040096461511911== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7575040096461511911==--