From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@linaro.org>
Cc: Amanieu <amanieu@gmail.com>,
Claudio Fontana <claudio.fontana@huawei.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64
Date: Thu, 23 Oct 2014 10:31:58 -0700 [thread overview]
Message-ID: <54493B8E.7020901@twiddle.net> (raw)
In-Reply-To: <CAFEAcA8uDvuORyJ-NdR_SYRkF9PX4D4o=4-S_8fZmdCbkb9pSA@mail.gmail.com>
On 10/23/2014 05:06 AM, Peter Maydell wrote:
> On 23 October 2014 12:55, <riku.voipio@linaro.org> wrote:
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits
>> because the fault address passes through an uint32_t variable. This
>> is fixed by changing the variable to uint64_t.
>>
>> v2 by Riku - follow Peters suggestion and drop the addr variable
>> since its only used once in the Aarch64 loop.
>>
>> Reported-by: Amanieu d'Antras <amanieu@gmail.com>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>
> Ah, I was just wondering this morning whether I ought
> to do a version of this patch, so you've saved me the effort :-)
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> (You might want to put the notes about v2 below the '---'.)
If you do that, please just modify the entire patch description.
I.e. don't talk about the type of a variable that doesn't exist.
r~
next prev parent reply other threads:[~2014-10-23 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 11:55 [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64 riku.voipio
2014-10-23 12:06 ` Peter Maydell
2014-10-23 17:31 ` Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-10 4:22 Amanieu d'Antras
2014-10-10 8:02 ` Claudio Fontana
2014-10-10 11:32 ` Peter Maydell
2014-10-10 14:58 ` Claudio Fontana
2014-10-10 15:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54493B8E.7020901@twiddle.net \
--to=rth@twiddle.net \
--cc=amanieu@gmail.com \
--cc=claudio.fontana@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.