From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for 4.5 v7 1/1] Add mmio_hole_size Date: Thu, 23 Oct 2014 21:39:01 +0100 Message-ID: <54496765.6030404@citrix.com> References: <1413204679-7345-1-git-send-email-dslutz@verizon.com> <1413204679-7345-2-git-send-email-dslutz@verizon.com> <1413814677.13796.10.camel@citrix.com> <54458621.3080102@terremark.com> <1413877953.20604.19.camel@citrix.com> <54493375.5040100@ihonk.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4723714296057229384==" Return-path: In-Reply-To: <54493375.5040100@ihonk.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Steve Freitas , Ian Campbell , Don Slutz Cc: Boris Ostrovsky , Stefano Stabellini , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============4723714296057229384== Content-Type: multipart/alternative; boundary="------------030507060206020108090902" This is a multi-part message in MIME format. --------------030507060206020108090902 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 23/10/2014 17:57, Steve Freitas wrote: > > On 10/21/2014 0:52, Ian Campbell wrote: >> >> On Mon, 2014-10-20 at 18:01 -0400, Don Slutz wrote: >> >> So I do not know which way to go here. >> >> I'm not sure why the fact that HVM_BELOW_4G_MMIO_LENGTH happens to be >> 256M right now should be of interest to the casual reader of this code. >> They can always lookup the #define. >> >> Putting the value of a define next to every use of it somewhat defeats >> the purpose of having a define. > > Hi guys, > > How's this looking for 4.5? :-D > > Steve Committed 9 hours ago. http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=2d927fc41b8e130b3b8910e4442d4691111d2ac7 ~Andrew --------------030507060206020108090902 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 23/10/2014 17:57, Steve Freitas wrote:

On 10/21/2014 0:52, Ian Campbell wrote:
On Mon, 2014-10-20 at 18:01 -0400, Don Slutz wrote:

So I do not know which way to go here.

I'm not sure why the fact that HVM_BELOW_4G_MMIO_LENGTH happens to be
256M right now should be of interest to the casual reader of this code.
They can always lookup the #define.

Putting the value of a define next to every use of it somewhat defeats
the purpose of having a define.

Hi guys,

How's this looking for 4.5? :-D

Steve

Committed 9 hours ago.

http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=2d927fc41b8e130b3b8910e4442d4691111d2ac7

~Andrew
--------------030507060206020108090902-- --===============4723714296057229384== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4723714296057229384==--