From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 4/6] dm: sunxi: Make sure that GPIOs are requested
Date: Fri, 24 Oct 2014 11:01:50 +0200 [thread overview]
Message-ID: <544A157E.6020806@redhat.com> (raw)
In-Reply-To: <1414036962-28463-5-git-send-email-sjg@chromium.org>
Hi,
On 10/23/2014 06:02 AM, Simon Glass wrote:
> The scsi_init() function uses a GPIO so should request it. There is no
> way to return an error here, and the request may be made multiple times,
> so just ignore errors for now.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Looks good:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
>
> Changes in v2: None
>
> board/sunxi/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/board/sunxi/ahci.c b/board/sunxi/ahci.c
> index 0c262ea..5e12328 100644
> --- a/board/sunxi/ahci.c
> +++ b/board/sunxi/ahci.c
> @@ -74,6 +74,7 @@ void scsi_init(void)
> {
> printf("SUNXI SCSI INIT\n");
> #ifdef CONFIG_SATAPWR
> + gpio_request(CONFIG_SATAPWR, "satapwr");
> gpio_direction_output(CONFIG_SATAPWR, 1);
> #endif
>
>
next prev parent reply other threads:[~2014-10-24 9:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 4:02 [U-Boot] [PATCH v2 0/6] dm: Introduce driver model for sunxi Simon Glass
2014-10-23 4:02 ` [U-Boot] [PATCH v2 1/6] dm: sunxi: dts: Add sun7i device tree files Simon Glass
2014-10-24 8:32 ` [U-Boot] [U-Boot, v2, " Hans de Goede
2014-10-28 1:05 ` Simon Glass
2014-10-23 4:02 ` [U-Boot] [PATCH v2 2/6] dm: sunxi: Add a new config for an FDT-based pcDuino3 Simon Glass
2014-10-24 8:38 ` [U-Boot] [U-Boot, v2, " Hans de Goede
2014-10-28 0:04 ` Simon Glass
2014-10-28 9:13 ` Hans de Goede
2014-10-29 3:02 ` Simon Glass
2014-10-29 9:32 ` Hans de Goede
2014-10-29 19:30 ` Simon Glass
2014-10-30 8:36 ` Hans de Goede
2014-10-23 4:02 ` [U-Boot] [PATCH v2 3/6] dm: sunxi: Add pinmux functions which take a bank parameter Simon Glass
2014-10-24 9:00 ` [U-Boot] [U-Boot, v2, " Hans de Goede
2014-10-23 4:02 ` [U-Boot] [PATCH v2 4/6] dm: sunxi: Make sure that GPIOs are requested Simon Glass
2014-10-24 9:01 ` Hans de Goede [this message]
2014-10-23 4:02 ` [U-Boot] [PATCH v2 5/6] dm: sunxi: Modify the GPIO driver to support driver model Simon Glass
2014-10-24 9:08 ` [U-Boot] [U-Boot, v2, " Hans de Goede
2014-10-28 0:05 ` Simon Glass
2014-10-28 2:53 ` Chen-Yu Tsai
2014-10-28 3:29 ` Simon Glass
2014-10-28 3:39 ` Chen-Yu Tsai
2014-10-28 14:30 ` Maxime Ripard
2014-10-23 4:02 ` [U-Boot] [PATCH v2 6/6] dm: sunxi: Add support for serial using " Simon Glass
2014-10-24 9:10 ` [U-Boot] [U-Boot, v2, " Hans de Goede
2014-10-24 9:42 ` [U-Boot] [PATCH v2 " Ian Campbell
2014-10-28 0:06 ` Simon Glass
2014-10-29 8:05 ` Ian Campbell
2014-10-29 19:28 ` Simon Glass
2014-10-30 9:08 ` Ian Campbell
2014-10-30 9:36 ` Hans de Goede
2014-10-30 10:14 ` Ian Campbell
2014-10-31 2:45 ` Simon Glass
2014-10-31 9:07 ` Hans de Goede
2014-10-31 9:30 ` Ian Campbell
2014-10-31 9:33 ` Hans de Goede
2014-10-31 9:55 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A157E.6020806@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.