From: Matthias Fuchs <matthias.fuchs@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: update PMC440 board support
Date: Fri, 24 Oct 2014 12:52:16 +0200 [thread overview]
Message-ID: <544A2F60.3040609@esd.eu> (raw)
In-Reply-To: <20141023180921.29c41a7a@crub>
Hi Anatolij,
On 10/23/2014 06:09 PM, Anatolij Gustschin wrote:
> Hi Matthias,
>
> On Thu, 23 Oct 2014 17:50:23 +0200
> Matthias Fuchs <matthias.fuchs@esd.eu> wrote:
> ...
>> diff --git a/include/configs/PMC440.h b/include/configs/PMC440.h
>> index c5e2f16..dc2c976 100644
>> --- a/include/configs/PMC440.h
>> +++ b/include/configs/PMC440.h
>> @@ -29,6 +29,8 @@
>> #define CONFIG_SYS_TEXT_BASE 0xFFF90000
>> #endif
>>
>> +#define CONFIG_SYS_GENERIC_BOARD
>
> you also need
>
> #define CONFIG_DISPLAY_BOARDINFO
>
> Otherwise the checkboard() won't get called and the board revision
> detection will be skipped. This will affect reset_phy() later.
> Please check.
>
> Thanks,
>
> Anatolij
>
>
good catch. I did'n noticed the missing output line. v2 patch
is on the road.
Matthias
next prev parent reply other threads:[~2014-10-24 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:50 [U-Boot] [PATCH] ppc4xx: update PMC440 board support Matthias Fuchs
2014-10-23 16:09 ` Anatolij Gustschin
2014-10-24 10:52 ` Matthias Fuchs [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-28 12:36 [U-Boot] [PATCH] ppc4xx: Handle other board variant in PMC440 FPGA code matthias.fuchs at esd-electronics.com
2008-10-28 12:36 ` [U-Boot] [PATCH] ppc4xx: Clean up PMC440 header matthias.fuchs at esd-electronics.com
2008-10-28 12:36 ` [U-Boot] [PATCH] ppc4xx: Fix esd loadpci command matthias.fuchs at esd-electronics.com
2008-10-28 12:36 ` [U-Boot] [PATCH] ppc4xx: Update PMC440 board configuration matthias.fuchs at esd-electronics.com
2008-10-28 12:36 ` [U-Boot] [PATCH] ppc4xx: Fix PMC440 BSP commands matthias.fuchs at esd-electronics.com
2008-10-28 12:37 ` [U-Boot] [PATCH] ppc4xx: Update PMC440 board support matthias.fuchs at esd-electronics.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A2F60.3040609@esd.eu \
--to=matthias.fuchs@esd.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.