From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC Date: Fri, 24 Oct 2014 15:34:48 +0200 Message-ID: <544A5578.7030009@samsung.com> References: <1413775749-17539-1-git-send-email-cw00.choi@samsung.com> <1413775935-17743-5-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:45854 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756582AbaJXNex (ORCPT ); Fri, 24 Oct 2014 09:34:53 -0400 In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Daniel Drake , Chanwoo Choi Cc: linux-samsung-soc , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , Kukjin Kim , ben-linux@fluff.org, Russell King , Mark Rutland , Arnd Bergmann , Olof Johansson , Tomasz Figa , Mike Turquette , thomas.abraham@linaro.org, Linus Walleij , Seung-Woo Kim , Kyungmin Park , InKi Dae , geunsik.lim@samsung.com, jh80.chung@samsung.com, jaewon02.kim@samsung.com, ideal.song@samsung.com, yj44.cho@samsung.com Hello, On 2014-10-24 15:23, Daniel Drake wrote: > On Sun, Oct 19, 2014 at 9:32 PM, Chanwoo Choi wrote: >> This patch adds new exynos4415.dtsi to support Exynos4415 SoC >> based on Cortex-A9 quad cores and includes following dt nodes: > There's a lot in common between your new exynos4415.dtsi and the > existing exynos4.dtsi. > Would it make more sense for the 4415 code to extend the existing > exynos4.dtsi like the other Exynos4 variants do? Well, I also thought about such approach, but there are some fundamental differences: interrupt and clock controllers are completely different. Using a common exynos4.dtsi and overriding them in every node will result in a code, which is a bit hard to follow. IMHO with such differences justifies using separate base dtsi file. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Fri, 24 Oct 2014 15:34:48 +0200 Subject: [PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC In-Reply-To: References: <1413775749-17539-1-git-send-email-cw00.choi@samsung.com> <1413775935-17743-5-git-send-email-cw00.choi@samsung.com> Message-ID: <544A5578.7030009@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On 2014-10-24 15:23, Daniel Drake wrote: > On Sun, Oct 19, 2014 at 9:32 PM, Chanwoo Choi wrote: >> This patch adds new exynos4415.dtsi to support Exynos4415 SoC >> based on Cortex-A9 quad cores and includes following dt nodes: > There's a lot in common between your new exynos4415.dtsi and the > existing exynos4.dtsi. > Would it make more sense for the 4415 code to extend the existing > exynos4.dtsi like the other Exynos4 variants do? Well, I also thought about such approach, but there are some fundamental differences: interrupt and clock controllers are completely different. Using a common exynos4.dtsi and overriding them in every node will result in a code, which is a bit hard to follow. IMHO with such differences justifies using separate base dtsi file. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland