From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhhPY-0005XE-MK for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:08:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhhPS-0001H8-II for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:08:20 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:7453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhhPS-0001Go-BK for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:08:14 -0400 Message-ID: <544A7969.90200@imgtec.com> Date: Fri, 24 Oct 2014 17:08:09 +0100 From: Leon Alrae MIME-Version: 1.0 References: <20141021121453.7268.529.stgit@PASHA-ISP> <5449299B.9070902@twiddle.net> In-Reply-To: <5449299B.9070902@twiddle.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] arm: fix TB alignment check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, zealot351@gmail.com, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, batuzovk@ispras.ru On 23/10/2014 17:15, Richard Henderson wrote: > [3] Hello, MIPS. Leon, the test for mips is (now) incorrect: > > if ((ctx.pc & (TARGET_PAGE_SIZE - 1)) == 0) > break; > > may never succeed for mips16 and micromips. Indeed, this test doesn't look right (although I'm not sure what exactly are the consequences if the test doesn't succeed and we span two or more pages). Thanks for spotting this in MIPS. Regards, Leon