All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Backlund <tmb@mageia.org>
To: netfilter-devel@vger.kernel.org
Cc: kadlec@blackhole.kfki.hu
Subject: [PATCH] add missing ipset_parse_tcp_udp_port to libipset.map
Date: Fri, 24 Oct 2014 22:22:14 +0259	[thread overview]
Message-ID: <544AA6FF.1000803@mageia.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

Found this issue when we switched from 6.19 static build to 6.21 dynamic 
build, and is still there in 6.23

--
Thomas

[-- Attachment #2: ipset-6.23-add-missing-ipset_parse_tcp_udp_port.patch --]
[-- Type: text/x-patch, Size: 1390 bytes --]


Commit: 

author	Quentin Armitage <quentin@armitage.org.uk>	2013-08-09 11:26:33 (GMT)
committer	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>	2013-08-17 19:31:29 (GMT)
commit	480761a3bdaa55bf8c966e4dab950ebf84775863 (patch)
tree	6d750f948abf1ae4f93e4c704502d085ac13d679
parent	3a4419954a3ae0ba5dafd711e6b8dd8f0beb5c21 (diff)
Add specifying protocol for bitmap:port
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

added ipset_parse_tcp_udp_port, but forgot to update libipset.map

so we get:

# ipset list
/usr/lib64/ipset/ipset_bitmap_port.so: /usr/lib64/ipset/ipset_bitmap_port.so: undefined symbol: ipset_parse_tcp_udp_port

so update the map.

Signed-off-by: Thomas Backlund <tmb@mageia.org>


---
Note, this patch is against a build that also has the ipset_parse_uint16 added:
http://www.spinics.net/lists/netfilter-devel/msg33805.html

Since there is now 2 issues, what should be done for:
"bump API curr and age in Make_global.am and add a new section to libipset.map"

diff -Nurp ipset-6.23.old/lib/libipset.map ipset-6.23/lib/libipset.map
--- ipset-6.23.old/lib/libipset.map	2014-10-24 21:34:52.000000000 +0300
+++ ipset-6.23/lib/libipset.map	2014-10-24 21:45:46.502262622 +0300
@@ -149,6 +149,7 @@ LIBIPSET_4.3 {
 global:
   ipset_parse_skbmark;
   ipset_parse_skbprio;
+  ipset_parse_tcp_udp_port;
   ipset_parse_uint16;
   ipset_print_skbmark;
   ipset_print_skbprio;

             reply	other threads:[~2014-10-24 19:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 19:23 Thomas Backlund [this message]
2014-10-24 20:08 ` [PATCH] add missing ipset_parse_tcp_udp_port to libipset.map Jan Engelhardt
2014-10-24 20:36   ` [PATCH v2] " Thomas Backlund
2014-10-28 18:38     ` Jozsef Kadlecsik
2014-10-24 20:44   ` [PATCH] " Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544AA6FF.1000803@mageia.org \
    --to=tmb@mageia.org \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.