From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id ACC5BE007B9; Fri, 24 Oct 2014 13:02:17 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9E2ADE00796 for ; Fri, 24 Oct 2014 13:02:02 -0700 (PDT) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id 28CD1F811E3; Fri, 24 Oct 2014 14:02:01 -0600 (MDT) Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 58C43F811E2; Fri, 24 Oct 2014 14:02:00 -0600 (MDT) Message-ID: <544AB060.7030101@mlbassoc.com> Date: Fri, 24 Oct 2014 14:02:40 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: meta-freescale@yoctoproject.org References: <1414176619-26876-1-git-send-email-daiane.angolini@freescale.com> In-Reply-To: Subject: Re: [meta-fsl-arm-extra][PATCH] imx6dl-riotboard: Add support for RIoT board X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2014 20:02:17 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 2014-10-24 13:09, Fabio Estevam wrote: > On Fri, Oct 24, 2014 at 4:50 PM, Daiane Angolini > wrote: >> Signed-off-by: Daiane Angolini > > A brief commit log would be helpful and also a link to > http://riotboard.org/ could help so people can know the details about > the board. > >> --- >> conf/machine/imx6dl-riotboard.conf | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 conf/machine/imx6dl-riotboard.conf >> >> diff --git a/conf/machine/imx6dl-riotboard.conf b/conf/machine/imx6dl-riotboard.conf >> new file mode 100644 >> index 0000000..fc6dd42 >> --- /dev/null >> +++ b/conf/machine/imx6dl-riotboard.conf >> @@ -0,0 +1,17 @@ >> +#@TYPE: Machine >> +#@NAME: RIoTboard >> +#@SOC: i.MX6S >> +#@DESCRIPTION: Machine configuration for i.MX6S RIoTboard. >> +#@MAINTAINER: Daiane Angolini >> + >> +include conf/machine/include/imx-base.inc >> +include conf/machine/include/tune-cortexa9.inc >> + >> +SOC_FAMILY = "mx6:mx6dl" >> + >> +UBOOT_MACHINE = "riotboard_defconfig" >> + >> +PREFERRED_PROVIDER_virtual/kernel ?= "linux-fslc" >> +KERNEL_DEVICETREE = "imx6dl-riotboard.dtb" >> + >> +SERIAL_CONSOLE = "115200 ttymxc1" > > Patch looks good, but just a general comment about SERIAL_CONSOLE: do > we really need to hardcode the ttymxcX node in the conf files? > > Can't this just be passed by the bootloader or via 'stdout-path' in the dts? > > If someone wants to test this same rootfs on a board that uses ttymxc0 > then it is not possible due to the mismatch caused by SERIAL_CONSOLE. > > What happens if SERIAL_CONSOLE is not passed or if only > "SERIAL_CONSOLE = "115200" is passed? > At least if you are using sysvinit, this is how the choice of where to put the system login is specified. (I'm not sure of systemd - I don't use that) -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------