From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Fri, 24 Oct 2014 22:14:55 +0200 Subject: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct In-Reply-To: <544629F0.3090505@gmail.com> References: <1413882477-27922-1-git-send-email-sebastian.hesselbarth@gmail.com> <1413882477-27922-2-git-send-email-sebastian.hesselbarth@gmail.com> <54462865.6000205@ti.com> <544629F0.3090505@gmail.com> Message-ID: <544AB33F.9030701@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 21.10.2014 11:40, Sebastian Hesselbarth wrote: > On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: >> On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: >>> Currently, Berlin SATA PHY driver assumes PHY_BASE address being >>> constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BASE >>> is different. Prepare the driver for BG2 support by moving the phy_base >>> into private driver data. >>> >>> Acked-by: Antoine T?nart >>> Signed-off-by: Sebastian Hesselbarth > ... >>> --- >>> drivers/phy/phy-berlin-sata.c | 42 >>> ++++++++++++++++++++++++++++-------------- >>> 1 file changed, 28 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/phy/phy-berlin-sata.c >>> b/drivers/phy/phy-berlin-sata.c >>> index 69ced52d72aa..9682b0f66177 100644 >>> --- a/drivers/phy/phy-berlin-sata.c >>> +++ b/drivers/phy/phy-berlin-sata.c >>> @@ -30,7 +30,7 @@ >>> #define MBUS_WRITE_REQUEST_SIZE_128 (BIT(2) << 16) >>> #define MBUS_READ_REQUEST_SIZE_128 (BIT(2) << 19) >>> >>> -#define PHY_BASE 0x200 >>> +#define BG2Q_PHY_BASE 0x200 > [...] >>> +static u32 bg2q_sata_phy_base = BG2Q_PHY_BASE; >>> + >>> +static const struct of_device_id phy_berlin_sata_of_match[] = { >>> + { >>> + .compatible = "marvell,berlin2q-sata-phy", >>> + .data = &bg2q_sata_phy_base, >> >> Can't the base directly come from dt? > > You are suggesting a "marvell,phy-base-address" property, right? > I have no strong opinion about it, I accept your call (or DT maintainer > ones). Kishon, I still have the DT patches for BG2Q queued up for v3.19 (I missed the arm-soc merge window for v3.18). That means, there has been no release with the phy binding used and I can rework a little more. Can you please confirm that you want a DT property for the phy base address, e.g. marvell,phy-base-address = <{0x200,0x80}> ? If so, I'd also rename the compatible from berlin2q-sata-phy to more generic berlin-sata-phy. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct Date: Fri, 24 Oct 2014 22:14:55 +0200 Message-ID: <544AB33F.9030701@gmail.com> References: <1413882477-27922-1-git-send-email-sebastian.hesselbarth@gmail.com> <1413882477-27922-2-git-send-email-sebastian.hesselbarth@gmail.com> <54462865.6000205@ti.com> <544629F0.3090505@gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <544629F0.3090505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I Cc: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 21.10.2014 11:40, Sebastian Hesselbarth wrote: > On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: >> On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: >>> Currently, Berlin SATA PHY driver assumes PHY_BASE address being >>> constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BA= SE >>> is different. Prepare the driver for BG2 support by moving the phy_= base >>> into private driver data. >>> >>> Acked-by: Antoine T=C3=A9nart >>> Signed-off-by: Sebastian Hesselbarth > ... >>> --- >>> drivers/phy/phy-berlin-sata.c | 42 >>> ++++++++++++++++++++++++++++-------------- >>> 1 file changed, 28 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/phy/phy-berlin-sata.c >>> b/drivers/phy/phy-berlin-sata.c >>> index 69ced52d72aa..9682b0f66177 100644 >>> --- a/drivers/phy/phy-berlin-sata.c >>> +++ b/drivers/phy/phy-berlin-sata.c >>> @@ -30,7 +30,7 @@ >>> #define MBUS_WRITE_REQUEST_SIZE_128 (BIT(2) << 16) >>> #define MBUS_READ_REQUEST_SIZE_128 (BIT(2) << 19) >>> >>> -#define PHY_BASE 0x200 >>> +#define BG2Q_PHY_BASE 0x200 > [...] >>> +static u32 bg2q_sata_phy_base =3D BG2Q_PHY_BASE; >>> + >>> +static const struct of_device_id phy_berlin_sata_of_match[] =3D { >>> + { >>> + .compatible =3D "marvell,berlin2q-sata-phy", >>> + .data =3D &bg2q_sata_phy_base, >> >> Can't the base directly come from dt? > > You are suggesting a "marvell,phy-base-address" property, right? > I have no strong opinion about it, I accept your call (or DT maintain= er > ones). Kishon, I still have the DT patches for BG2Q queued up for v3.19 (I missed the arm-soc merge window for v3.18). That means, there has been no release with the phy binding used and I can rework a little more. Can you please confirm that you want a DT property for the phy base=20 address, e.g. marvell,phy-base-address =3D <{0x200,0x80}> ? If so, I'd also rename the compatible from berlin2q-sata-phy to more generic berlin-sata-phy. Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755759AbaJXUPF (ORCPT ); Fri, 24 Oct 2014 16:15:05 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:33554 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753906AbaJXUPD (ORCPT ); Fri, 24 Oct 2014 16:15:03 -0400 Message-ID: <544AB33F.9030701@gmail.com> Date: Fri, 24 Oct 2014 22:14:55 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 To: Kishon Vijay Abraham I CC: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct References: <1413882477-27922-1-git-send-email-sebastian.hesselbarth@gmail.com> <1413882477-27922-2-git-send-email-sebastian.hesselbarth@gmail.com> <54462865.6000205@ti.com> <544629F0.3090505@gmail.com> In-Reply-To: <544629F0.3090505@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.10.2014 11:40, Sebastian Hesselbarth wrote: > On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: >> On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: >>> Currently, Berlin SATA PHY driver assumes PHY_BASE address being >>> constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BASE >>> is different. Prepare the driver for BG2 support by moving the phy_base >>> into private driver data. >>> >>> Acked-by: Antoine Ténart >>> Signed-off-by: Sebastian Hesselbarth > ... >>> --- >>> drivers/phy/phy-berlin-sata.c | 42 >>> ++++++++++++++++++++++++++++-------------- >>> 1 file changed, 28 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/phy/phy-berlin-sata.c >>> b/drivers/phy/phy-berlin-sata.c >>> index 69ced52d72aa..9682b0f66177 100644 >>> --- a/drivers/phy/phy-berlin-sata.c >>> +++ b/drivers/phy/phy-berlin-sata.c >>> @@ -30,7 +30,7 @@ >>> #define MBUS_WRITE_REQUEST_SIZE_128 (BIT(2) << 16) >>> #define MBUS_READ_REQUEST_SIZE_128 (BIT(2) << 19) >>> >>> -#define PHY_BASE 0x200 >>> +#define BG2Q_PHY_BASE 0x200 > [...] >>> +static u32 bg2q_sata_phy_base = BG2Q_PHY_BASE; >>> + >>> +static const struct of_device_id phy_berlin_sata_of_match[] = { >>> + { >>> + .compatible = "marvell,berlin2q-sata-phy", >>> + .data = &bg2q_sata_phy_base, >> >> Can't the base directly come from dt? > > You are suggesting a "marvell,phy-base-address" property, right? > I have no strong opinion about it, I accept your call (or DT maintainer > ones). Kishon, I still have the DT patches for BG2Q queued up for v3.19 (I missed the arm-soc merge window for v3.18). That means, there has been no release with the phy binding used and I can rework a little more. Can you please confirm that you want a DT property for the phy base address, e.g. marvell,phy-base-address = <{0x200,0x80}> ? If so, I'd also rename the compatible from berlin2q-sata-phy to more generic berlin-sata-phy. Sebastian