From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= Date: Sat, 25 Oct 2014 00:23:29 +0200 Subject: [U-Boot] [PATCH 2/3] net: macb: enable GMAC IP without GE feature support In-Reply-To: <1410854244-30424-3-git-send-email-voice.shen@atmel.com> References: <1410854244-30424-1-git-send-email-voice.shen@atmel.com> <1410854244-30424-3-git-send-email-voice.shen@atmel.com> Message-ID: <544AD161.3020606@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bo, On 16.09.14 09:57, Bo Shen wrote: > The User Register in GMAC IP is used to select interface type. > When with GE feature, it is used to select interface between > RGMII and GMII. If without GE feature, it is used to select > interface between MII and RMII. > > Signed-off-by: Bo Shen > --- > > drivers/net/macb.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 01a94a4..369d155 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -574,7 +574,13 @@ static int macb_init(struct eth_device *netdev, bd_t *bd) > macb_writel(macb, TBQP, macb->tx_ring_dma); > > if (macb_is_gem(macb)) { > -#ifdef CONFIG_RGMII > + /* > + * When the GMAC IP with GE feature, this bit is used to > + * select interface between RGMII and GMII. > + * When the GMAC IP without GE feature, this bit is used > + * to select interface between RMII and MII. > + */ > +#if defined(CONFIG_RGMII) || defined(CONFIG_RMII) > gem_writel(macb, UR, GEM_BIT(RGMII)); > #else > gem_writel(macb, UR, 0); > looks good Best regards Andreas Bie?mann