From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= Date: Sat, 25 Oct 2014 02:37:44 +0200 Subject: [U-Boot] [PATCH v1 01/10] arm, at91, mpddrc: fix typo in ddr2_init() In-Reply-To: <1412142894-997-2-git-send-email-hs@denx.de> References: <1412142894-997-1-git-send-email-hs@denx.de> <1412142894-997-2-git-send-email-hs@denx.de> Message-ID: <544AF0D8.9000000@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Heiko, On 01.10.14 07:54, Heiko Schocher wrote: > use the configure value for computing the ba_off value > not the value from the cr register. This leaded in a > wrong ram configuration on the upcoming corvus spl board > support. > > Signed-off-by: Heiko Schocher > Cc: Andreas Bie?mann > Cc: Bo Shen Reviewed-by: Andreas Bie?mann > --- > arch/arm/cpu/at91-common/mpddrc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/cpu/at91-common/mpddrc.c b/arch/arm/cpu/at91-common/mpddrc.c > index 8136396..76668d2 100644 > --- a/arch/arm/cpu/at91-common/mpddrc.c > +++ b/arch/arm/cpu/at91-common/mpddrc.c > @@ -26,7 +26,8 @@ int ddr2_init(const unsigned int ram_address, > /* Compute bank offset according to NC in configuration register */ > ba_off = (mpddr_value->cr & ATMEL_MPDDRC_CR_NC_MASK) + 9; > if (!(mpddr_value->cr & ATMEL_MPDDRC_CR_DECOD_INTERLEAVED)) > - ba_off += ((mpddr->cr & ATMEL_MPDDRC_CR_NR_MASK) >> 2) + 11; > + ba_off += ((mpddr_value->cr & ATMEL_MPDDRC_CR_NR_MASK) >> 2) > + + 11; ugly 80 char rule ... > > ba_off += (mpddr_value->md & ATMEL_MPDDRC_MD_DBW_MASK) ? 1 : 2; > >