Re: [PATCH v2] bmp280: use correct routine for division

[Jonathan Cameron <jic23@kernel.org>]

On 23/10/14 15:52, Vlad Dogaru wrote:
> The proper way to divide two signed 64-bit values is to use div64_s64.
> 
> Signed-off-by: Vlad Dogaru <vlad.dogaru@intel.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
Applied to the togreg branch of iio.git - initially pushed out as testing.
Thanks,.

Jonathan
> ---
> 
> Since v1: fix typo in commit message.
> 
>  drivers/iio/pressure/bmp280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/pressure/bmp280.c b/drivers/iio/pressure/bmp280.c
> index fb91cb3..ce29ff9 100644
> --- a/drivers/iio/pressure/bmp280.c
> +++ b/drivers/iio/pressure/bmp280.c
> @@ -239,7 +239,7 @@ static u32 bmp280_compensate_press(struct bmp280_data *data,
>  		return 0;
>  
>  	p = ((((s64) 1048576 - adc_press) << 31) - var2) * 3125;
> -	do_div(p, var1);
> +	p = div64_s64(p, var1);
>  	var1 = (((s64) comp->dig_p9) * (p >> 13) * (p >> 13)) >> 25;
>  	var2 = (((s64) comp->dig_p8) * p) >> 19;
>  	p = ((p + var1 + var2) >> 8) + (((s64) comp->dig_p7) << 4);
>