From: Peter Lieven <pl@kamp.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: famz@redhat.com, benoit@irqsave.net, hutao@cn.fujitsu.com,
jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com, lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: qemu-iotests change _supported_proto to file once more.
Date: Sat, 25 Oct 2014 16:58:23 +0200 [thread overview]
Message-ID: <544BBA8F.5010908@kamp.de> (raw)
In-Reply-To: <20141022120323.GG3188@noname.str.redhat.com>
Am 22.10.2014 um 14:03 schrieb Kevin Wolf:
> Am 20.10.2014 um 13:47 hat Peter Lieven geschrieben:
>> In preparation to possible automatic regression and performance
>> testing for the block layer I found that the iotests don't work
>> for all protocols anymore.
>>
>> In commit 1f7bf7d0 I started to change supported protocols from
>> generic to file for various tests. Unfortunately, some tests
>> added in the meantime again carry generic protocol altough they
>> can only work with file because they require local file access.
>>
>> The other way around for some tests that only support file I added
>> NFS protocol after confirming they work.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
> Thanks, applied to the block branch.
>
> I suspect the test cases where you added nfs are actually generic. Did
> you check this?
Thinking about this again. Generic is probably wrong because
not all protocols support bdrv_create.
Peter
prev parent reply other threads:[~2014-10-25 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 11:47 [Qemu-devel] [PATCH] block: qemu-iotests change _supported_proto to file once more Peter Lieven
2014-10-20 13:11 ` Benoît Canet
2014-10-22 12:03 ` Kevin Wolf
2014-10-22 13:08 ` Peter Lieven
2014-10-25 14:58 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544BBA8F.5010908@kamp.de \
--to=pl@kamp.de \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.