From: Jan Kiszka <jan.kiszka@web.de>
To: Knut Omang <knut.omang@oracle.com>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.a@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Alexander Graf" <agraf@suse.de>,
"Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <andreas.faerber@web.de>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Anthony Liguori" <aliguori@amazon.com>,
"Stefan Weil" <sw@weilnetz.de>,
qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges.
Date: Sun, 26 Oct 2014 13:06:47 +0100 [thread overview]
Message-ID: <544CE3D7.4060003@web.de> (raw)
In-Reply-To: <1413844443-28894-3-git-send-email-knut.omang@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On 2014-10-21 00:34, Knut Omang wrote:
> @@ -65,11 +66,12 @@ struct VTDContextCacheEntry {
> };
>
> struct VTDAddressSpace {
> - uint8_t bus_num;
> + PCIDevice *dev;
This change is not helpful for clean handling of non-PCI devices (i.e.
platform device interrupt remapping => you had to pull
Q35_PSEUDO_BUS_PLATFORM into intel_iommu, which is violating the
layering). Please leave bus_num in place - or convert to a 16-bit SID.
> uint8_t devfn;
> AddressSpace as;
> MemoryRegion iommu;
> IntelIOMMUState *iommu_state;
> + QLIST_ENTRY(VTDAddressSpace) iommu_next; /* For traversal by the iommu */
> VTDContextCacheEntry context_cache_entry;
> };
>
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-10-26 12:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 22:34 [Qemu-devel] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges Knut Omang
2014-10-20 22:34 ` [Qemu-devel] [PATCH 1/2] iommu: Replace bus+devfn arguments with PCIDevice* in PCIIOMMUFunc Knut Omang
2014-10-20 22:34 ` [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges Knut Omang
2014-10-25 11:36 ` Jan Kiszka
2014-10-25 12:24 ` Jan Kiszka
2014-10-26 4:46 ` Knut Omang
2014-10-25 12:28 ` Jan Kiszka
2014-10-26 12:06 ` Jan Kiszka [this message]
2014-10-26 13:15 ` Knut Omang
2014-10-26 15:20 ` Michael S. Tsirkin
2014-10-20 23:29 ` [Qemu-devel] [PATCH 0/2] " Alexander Graf
2014-10-21 5:26 ` Knut Omang
2014-10-21 9:07 ` Alexander Graf
2014-10-21 9:35 ` Knut Omang
2014-10-21 11:15 ` Alexander Graf
2014-10-21 11:26 ` Michael S. Tsirkin
2014-10-21 11:37 ` Knut Omang
2014-10-21 12:20 ` Michael S. Tsirkin
2014-10-21 15:07 ` Alex Williamson
2014-10-21 22:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544CE3D7.4060003@web.de \
--to=jan.kiszka@web.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=andreas.faerber@web.de \
--cc=armbru@redhat.com \
--cc=hpoussin@reactos.org \
--cc=knut.omang@oracle.com \
--cc=marcel.a@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.