From: Gioh Kim <gioh.kim@lge.com>
To: Laura Abbott <lauraa@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
Rebecca Schultz Zavin <rebecca@android.com>
Cc: devel@driverdev.osuosl.org, gunho.lee@lge.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFCv2 1/3] staging: ion: shrink page-pool by page unit
Date: Mon, 27 Oct 2014 09:01:40 +0900 [thread overview]
Message-ID: <544D8B64.3010501@lge.com> (raw)
In-Reply-To: <544AB20A.8090208@codeaurora.org>
2014-10-25 오전 5:09, Laura Abbott 쓴 글:
> Hi,
>
> On 10/23/2014 11:47 PM, Gioh Kim wrote:
>> This patch shrink page-pool by page unit.
>>
>
> Can you explain a bit more about what this patch is
> fixing? The description in the cover letter would
> be helpful here.
I'm sorry for the lack of explanation.
First, I wanted to shrink ion page-pool, but there was no way for it.
So I checked the existing codes and found a problem.
ion_page_pool_total() returns the number of pages in the pool,
so ion_heap_shrink_count() returns also the number of pages.
ion_page_pool_shrink() takes the argument nr_to_scan as the number of chunk, a bunch of pages.
The system shrinker calls ion_heap_shrink_count() to get nr_to_scan,
and pass it to ion_page_pool_shrink().
The problem is the argument of ion_page_pool_shrink() is the amount of chunk to be shrinked.
We have to make both of them take number of page or chunk respectively.
The first patch is doing it.
The second one is, based on the first patch, making shrink interface via debugfs.
The third is for extra interface.
>
> Thanks,
> Laura
>
next prev parent reply other threads:[~2014-10-27 0:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 6:47 [RFCv2 0/3] enable pool shrinking in page unit Gioh Kim
2014-10-24 6:47 ` [RFCv2 1/3] staging: ion: shrink page-pool by " Gioh Kim
2014-10-24 20:09 ` Laura Abbott
2014-10-27 0:01 ` Gioh Kim [this message]
2014-10-24 6:47 ` [RFCv2 2/3] staging: ion: debugfs to shrink pool Gioh Kim
2014-10-24 20:38 ` Laura Abbott
2014-10-27 0:24 ` Gioh Kim
2014-10-24 6:47 ` [RFCv2 3/3] staging: ion: limit pool size Gioh Kim
2014-10-24 20:53 ` Laura Abbott
2014-10-27 0:48 ` Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544D8B64.3010501@lge.com \
--to=gioh.kim@lge.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gunho.lee@lge.com \
--cc=john.stultz@linaro.org \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rebecca@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.