From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [PATCH] xen/vtd: cleanup some comments
Date: Mon, 27 Oct 2014 09:33:29 +0800
Message-ID: <544DA0E9.3000306@intel.com>
References: <1414119041-17891-1-git-send-email-tiejun.chen@intel.com>
	<544A46FE0200007800041DA2@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <544A46FE0200007800041DA2@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 2014/10/24 18:33, Jan Beulich wrote:
>>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
>>
>>       if ( !iommu_passthrough && !need_iommu(d) )
>>       {
>> -        /* Set up 1:1 page table for dom0 */
>> +        /* Set up 1:1 page table for hardware domain */
>>           vtd_set_hwdom_mapping(d);
>>       }
>>
>> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>>       if ( iommu_use_hap_pt(d) )
>>           return 0;
>>
>> -    /* do nothing if dom0 and iommu supports pass thru */
>> +    /* do nothing if hardware domain and iommu supports pass thru */
>
> If you clean up comments, please make them match ./CODING_STYLE.

Sorry, could you say this explicitly?

 From my point of view, this is just one line and this line is already 
less than 80 characters in length. Or just add a period at the end of 
the sentence?

Thanks
Tiejun