From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XigIB-00079R-OL for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:08:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XigI2-00015G-UB for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:08:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XigI2-000156-Mt for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:08:38 -0400 Message-ID: <544E0B8E.70005@redhat.com> Date: Mon, 27 Oct 2014 10:08:30 +0100 From: Max Reitz MIME-Version: 1.0 References: <1414256153-10148-1-git-send-email-pl@kamp.de> <1414256153-10148-6-git-send-email-pl@kamp.de> In-Reply-To: <1414256153-10148-6-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 5/6] block: add qemu-iotest for write-merge parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, armbru@redhat.com, stefanha@redhat.com On 2014-10-25 at 18:55, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > tests/qemu-iotests/109 | 113 ++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/109.out | 68 ++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 182 insertions(+) > create mode 100755 tests/qemu-iotests/109 > create mode 100644 tests/qemu-iotests/109.out First: Reviewed-by: Max Reitz Second: Why are you using query-block at all? Just give both the format and the protocol BDS a (different) node name and you could use only query-named-block-nodes. Max