From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54689)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1XigM6-0004yl-Nc
	for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:12:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1XigM0-0002vI-TA
	for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:12:50 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:47438 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1XigM0-0002uz-K0
	for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:12:44 -0400
Message-ID: <544E0C85.4090301@kamp.de>
Date: Mon, 27 Oct 2014 10:12:37 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1414256153-10148-1-git-send-email-pl@kamp.de>
	<1414256153-10148-6-git-send-email-pl@kamp.de>
	<544E0B8E.70005@redhat.com>
In-Reply-To: <544E0B8E.70005@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCHv3 5/6] block: add qemu-iotest for
	write-merge parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, armbru@redhat.com, stefanha@redhat.com

On 27.10.2014 10:08, Max Reitz wrote:
> On 2014-10-25 at 18:55, Peter Lieven wrote:
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   tests/qemu-iotests/109     |  113 ++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/109.out |   68 ++++++++++++++++++++++++++
>>   tests/qemu-iotests/group   |    1 +
>>   3 files changed, 182 insertions(+)
>>   create mode 100755 tests/qemu-iotests/109
>>   create mode 100644 tests/qemu-iotests/109.out
>
> First:
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
> Second: Why are you using query-block at all? Just give both the format and the protocol BDS a (different) node name and you could use only query-named-block-nodes.

It was the useless try to make the lines shorter than 995 characters...

Peter

>
> Max


-- 

Mit freundlichen Grüßen

Peter Lieven

...........................................................

   KAMP Netzwerkdienste GmbH
   Vestische Str. 89-91 | 46117 Oberhausen
   Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
   pl@kamp.de | http://www.kamp.de

   Geschäftsführer: Heiner Lante | Michael Lante
   Amtsgericht Duisburg | HRB Nr. 12154
   USt-Id-Nr.: DE 120607556

...........................................................