From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects Date: Mon, 27 Oct 2014 18:14:54 +0900 Message-ID: <544E0D0E.6080206@daenzer.net> References: <88c64cce88264069e0e1637fc874e699e5b226f6.1414387334.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id E057789BAB for ; Mon, 27 Oct 2014 02:15:04 -0700 (PDT) In-Reply-To: <88c64cce88264069e0e1637fc874e699e5b226f6.1414387334.git.joe@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joe Perches , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMjcuMTAuMjAxNCAxNDoyNCwgSm9lIFBlcmNoZXMgd3JvdGU6Cj4gUHJlY2VkZW5jZSBvZiAm IGFuZCA+PiBpcyBub3QgdGhlIHNhbWUgYW5kIGlzIG5vdCBsZWZ0IHRvIHJpZ2h0Lgo+IHNoaWZ0 IGhhcyBoaWdoZXIgcHJlY2VkZW5jZSBhbmQgc2hvdWxkIGJlIGRvbmUgYWZ0ZXIgdGhlIG1hc2su Cj4KPiBBZGQgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSBtYXNrLgo+Cj4gVXNlIHRoZSBhbHJlYWR5 ICNkZWZpbmVkIHZhbHVlcyBpbnN0ZWFkIG9mIGhhcmRjb2RpbmcuCj4KPiBTaWduZWQtb2ZmLWJ5 OiBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9ldmVyZ3JlZW4uYyB8IDMgKystCj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9ldmVyZ3JlZW4uYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuLmMKPiBp bmRleCBhMzFmMWNhLi5hOTdhNjg1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRl b24vZXZlcmdyZWVuLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbi5j Cj4gQEAgLTMzMDMsNyArMzMwMyw4IEBAIHN0YXRpYyB2b2lkIGV2ZXJncmVlbl9ncHVfaW5pdChz dHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldikKPiAgIAlyZGV2LT5jb25maWcuZXZlcmdyZWVuLnRp bGVfY29uZmlnIHw9Cj4gICAJCSgoZ2JfYWRkcl9jb25maWcgJiAweDMwMDAwMDAwKSA+PiAyOCkg PDwgMTI7Cj4KPiAtCW51bV9zaGFkZXJfZW5naW5lcyA9IChnYl9hZGRyX2NvbmZpZyAmIE5VTV9T SEFERVJfRU5HSU5FUygzKSA+PiAxMikgKyAxOwo+ICsJbnVtX3NoYWRlcl9lbmdpbmVzID0gKChn Yl9hZGRyX2NvbmZpZyAmIE5VTV9TSEFERVJfRU5HSU5FU19NQVNLKQo+ICsJCQkgICAgICA+PiBO VU1fU0hBREVSX0VOR0lORVMpICsgMTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IF5eXl5eXl5eXl5eXl5eXl5eXgpJIHRoaW5rIHRoaXMgc2hvdWxkIGJlIE5VTV9TSEFERVJfRU5H SU5FU19TSElGVD8KCkxvb2tzIGdvb2QgdG8gbWUgb3RoZXIgdGhhbiB0aGF0LgoKCi0tIApFYXJ0 aGxpbmcgTWljaGVsIETDpG56ZXIgICAgICAgICAgICB8ICAgICAgICAgICAgICAgICAgaHR0cDov L3d3dy5hbWQuY29tCkxpYnJlIHNvZnR3YXJlIGVudGh1c2lhc3QgICAgICAgICAgfCAgICAgICAg ICAgICAgICBNZXNhIGFuZCBYIGRldmVsb3BlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbaJ0JU3 (ORCPT ); Mon, 27 Oct 2014 05:20:29 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:54070 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751318AbaJ0JU2 (ORCPT ); Mon, 27 Oct 2014 05:20:28 -0400 X-Greylist: delayed 322 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Oct 2014 05:20:28 EDT Message-ID: <544E0D0E.6080206@daenzer.net> Date: Mon, 27 Oct 2014 18:14:54 +0900 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:32.0) Gecko/20100101 Icedove/32.0 MIME-Version: 1.0 To: Joe Perches , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects References: <88c64cce88264069e0e1637fc874e699e5b226f6.1414387334.git.joe@perches.com> In-Reply-To: <88c64cce88264069e0e1637fc874e699e5b226f6.1414387334.git.joe@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.10.2014 14:24, Joe Perches wrote: > Precedence of & and >> is not the same and is not left to right. > shift has higher precedence and should be done after the mask. > > Add parentheses around the mask. > > Use the already #defined values instead of hardcoding. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/radeon/evergreen.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c > index a31f1ca..a97a685 100644 > --- a/drivers/gpu/drm/radeon/evergreen.c > +++ b/drivers/gpu/drm/radeon/evergreen.c > @@ -3303,7 +3303,8 @@ static void evergreen_gpu_init(struct radeon_device *rdev) > rdev->config.evergreen.tile_config |= > ((gb_addr_config & 0x30000000) >> 28) << 12; > > - num_shader_engines = (gb_addr_config & NUM_SHADER_ENGINES(3) >> 12) + 1; > + num_shader_engines = ((gb_addr_config & NUM_SHADER_ENGINES_MASK) > + >> NUM_SHADER_ENGINES) + 1; ^^^^^^^^^^^^^^^^^^ I think this should be NUM_SHADER_ENGINES_SHIFT? Looks good to me other than that. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer