From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xign2-0002Uh-6J for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:40:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xigmx-0003ms-25 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:40:40 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:11591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xigmw-0003lE-CY for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:40:34 -0400 Message-ID: <544E12FB.6070904@huawei.com> Date: Mon, 27 Oct 2014 17:40:11 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1413535838-11000-1-git-send-email-zhang.zhanghailiang@huawei.com> <5440DB35.9020507@huawei.com> <54484C88.3070305@huawei.com> In-Reply-To: <54484C88.3070305@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "lcapitulino@redhat.com" Cc: luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, Gonglei , imammedo@redhat.com, pbonzini@redhat.com Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) Thanks, zhanghailiang On 2014/10/23 8:32, zhanghailiang wrote: > Hi, > > Ping... > This patch has been reviewed, please pick up, Thanks. > > Best Regargs, > zhanghailiang > > On 2014/10/17 17:02, Gonglei wrote: >> On 2014/10/17 16:50, zhanghailiang wrote: >> >>> When do memory hotplug, if there is numa node, we should add >>> the memory size to the corresponding node memory size. >>> >>> For now, it mainly affects the result of hmp command "info numa". >>> >>> Reviewed-by: Igor Mammedov >>> Signed-off-by: zhanghailiang >>> --- >>> v6: >>> - remove unnecessary 'di' variable (GongLei) >>> v5: >>> - reword the subject (Igor Mammedov) >>> - turn query_numa_node_mem to void (Igor Mammedov) >>> v4: >>> - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) >>> - rewrite numa_stat_memory_devices and this will also fix compile error for >>> targets that don't support memory hotplug >>> v3: >>> - cold-plugged memory should not be excluded (Igor Mammedov) >>> v2: >>> - Don't modify the numa_info.node_mem directly when treating hotplug memory, >>> fix the "info numa" instead (Igor Mammedov) >>> >>> Thanks for review!;) >>> --- >>> >>> include/sysemu/sysemu.h | 1 + >>> monitor.c | 6 +++++- >>> numa.c | 38 ++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 44 insertions(+), 1 deletion(-) >>> >> >> Reviewed-by: Gonglei >> >> Best regards, >> -Gonglei >> >> >> . >> > > > > >