diff for duplicates of <544E19A4.6040603@collabora.co.uk> diff --git a/a/1.txt b/N1/1.txt index f5b198e..8e97a95 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -123,7 +123,7 @@ return regmap_update_bits(..., max77802->opmode[id] << shift); I think the max77802 driver approach is better since it avoids duplicating the switch statement to get the shift for each regulator. Just look how the max77802 -enable and disable functions are easier to read. Looking at the max77686 driver, +enable and disable functions are easier to read. Looking@the max77686 driver, I see that there are assumptions that opmode[id] has the value shifted so your changes are consistent with the rest of the driver but I would consider changing this. diff --git a/a/content_digest b/N1/content_digest index 32994a5..def0960 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,9 @@ "ref\01414403066-7872-1-git-send-email-k.kozlowski@samsung.com\0" "ref\01414403066-7872-3-git-send-email-k.kozlowski@samsung.com\0" - "From\0Javier Martinez Canillas <javier.martinez@collabora.co.uk>\0" - "Subject\0Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs\0" + "From\0javier.martinez@collabora.co.uk (Javier Martinez Canillas)\0" + "Subject\0[PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs\0" "Date\0Mon, 27 Oct 2014 11:08:36 +0100\0" - "To\0Krzysztof Kozlowski <k.kozlowski@samsung.com>" - Liam Girdwood <lgirdwood@gmail.com> - Mark Brown <broonie@kernel.org> - linux-kernel@vger.kernel.org - Ben Dooks <ben-linux@fluff.org> - Kukjin Kim <kgene.kim@samsung.com> - Russell King <linux@arm.linux.org.uk> - linux-arm-kernel@lists.infradead.org - linux-samsung-soc@vger.kernel.org - " devicetree@vger.kernel.org\0" - "Cc\0Kyungmin Park <kyungmin.park@samsung.com>" - Marek Szyprowski <m.szyprowski@samsung.com> - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - " Chanwoo Choi <cw00.choi@samsung.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hello Krzysztof,\n" @@ -144,7 +131,7 @@ "\n" "I think the max77802 driver approach is better since it avoids duplicating the\n" "switch statement to get the shift for each regulator. Just look how the max77802\n" - "enable and disable functions are easier to read. Looking at the max77686 driver,\n" + "enable and disable functions are easier to read. Looking@the max77686 driver,\n" "I see that there are assumptions that opmode[id] has the value shifted so your\n" "changes are consistent with the rest of the driver but I would consider changing\n" "this.\n" @@ -152,4 +139,4 @@ "Best regards,\n" Javier -2b90b1ff6580b3163890282fb68df1ad20b9051db94283c64af63321a19a8d4b +31ff996e4bbebecb382ff0680714e5556e07cc1a39131eed94aa38905229130e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.